Don't pass SRTP to the other leg on reinvite if it was not secured on initial invite #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dev-ryanc
requested changes
Mar 21, 2024
| @@ -5314,7 +5314,7 @@ static void check_stream_changes(switch_core_session_t *session, const char *r_s | |||
| switch_core_media_merge_sdp_codec_string(session, r_sdp, sdp_type, filter_codec_string); | |||
| } | |||
|
|
|||
| if (switch_channel_test_flag(session->channel, CF_SECURE)) { | |||
| if (switch_channel_test_flag(session->channel, CF_SECURE) && switch_channel_test_flag(other_session->channel, CF_SECURE)) { | |||
There was a problem hiding this comment.
I think we also need to check the other_session for CF_SECURE. For example if somehow the current session isn't secure but the partner session is secure then we still need to execute switch_core_session_check_outgoing_crypto. If both is secured then we will set the crypto_mode and call switch_core_session_check_outgoing_crypto
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.