TEL-6005: Initial implementation of RTCP-XR #295
+219
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damirn
requested review from
Elhodred,
dev-ryanc,
baloeng,
minhtuan1407-telnyx and
izzytelnyx
dev-ryanc
requested changes
Jun 24, 2024
src/switch_core_media.c
Outdated
| @@ -12243,8 +12246,10 @@ SWITCH_DECLARE(void) switch_core_media_gen_local_sdp(switch_core_session_t *sess | |||
| if (a_engine->rtcp_mux > 0) { | |||
| switch_snprintf(buf + strlen(buf), SDPBUFLEN - strlen(buf), "a=rtcp-mux\r\n"); | |||
| switch_snprintf(buf + strlen(buf), SDPBUFLEN - strlen(buf), "a=rtcp:%d IN %s %s\r\n", port, family, ip); | |||
| switch_snprintf(buf + strlen(buf), SDPBUFLEN - strlen(buf), "a=rtcp-xr:rcvr-rtt=all:10000 stat-summary=loss,dup,jitt,TTL voip-metrics\r\n"); | |||
There was a problem hiding this comment.
For now, we shouldn't offer/answer this by default. Please enable/disable this in two variables:
- Sofia Profiles
- Channel variables. (This variable should take precedence over sofia profiles)
If no configuration is set, its disable by default. Later when we decide to enable it by default then will just set it in sofia profiles via ansible
There was a problem hiding this comment.
Right, that was my initial idea, but I wanted to get this working ASAP, so it slipped my mind; will implement it.
…a the channel variable.
dev-ryanc
requested changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.