Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfixes + NumberLookup Endpoint #31

Merged
merged 4 commits into from
May 26, 2020
Merged

Bugfixes + NumberLookup Endpoint #31

merged 4 commits into from
May 26, 2020

Conversation

weroh
Copy link
Contributor

@weroh weroh commented May 22, 2020

Bugfixes

  • Changed the way we detect \Telnyx\Collection. If data is an array, then we assume it is a Collection. Change was made in ApiRequestor.php and Util.php
  • Fixed bugs in Portout, SimCard endpoints
  • Fixed tests for CallControlApplicationTest and SimCardTest
  • General code cleanup
  • Commented out tests in PortoutTest and SimCardTest
  • Added NumberLookup endpoint + Tests

weroh added 4 commits May 22, 2020 10:40
1. Changed the way we detect \Telnyx\Collection. If data is an array, then we assume it is a Collection. Change was made in ApiRequestor.php and Util.php
2. Fixed bugs in Portout, SimCard endpoints
3. Fixed tests for CallControlApplicationTest and SimCardTest
4. General code cleanup
- Added NumberLookup endpoint
- Commented out tests in PortoutTest and SimCardTest
- Commented out more SimCardTests
- Added NumberLookupTest
No changes. Ignore this.
@eoghantelnyx eoghantelnyx merged commit 66006bf into master May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants