Skip to content

Commit

Permalink
Merge 234de64 into 68ec33d
Browse files Browse the repository at this point in the history
  • Loading branch information
d-telnyx committed Sep 25, 2020
2 parents 68ec33d + 234de64 commit 3f6abc3
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 16 deletions.
6 changes: 3 additions & 3 deletions telnyx/api_resources/phone_number.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ class PhoneNumber(DeletableAPIResource, ListableAPIResource, UpdateableAPIResour

@classmethod
def all_voice(cls, **params):
""" Returns the voice settings for /all/ numbers owned by the user.
"""Returns the voice settings for /all/ numbers owned by the user.
This method breaks the naming convention of helper methods by adding
an `all_` prefix, which might be confusing at first. The reason for
Expand All @@ -51,7 +51,7 @@ def enable_emergency(self, **params):

@classmethod
def all_messaging(cls, **params):
""" Returns the messaging settings for /all/ numbers owned by the
"""Returns the messaging settings for /all/ numbers owned by the
user.
See the documentation for `all_voice()` for an explanation on the
Expand All @@ -61,7 +61,7 @@ def all_messaging(cls, **params):
return PhoneNumber.list_messaging(None, **params)

def messaging(self, **params):
""" Returns the messaging settings for the instantiated phone
"""Returns the messaging settings for the instantiated phone
number.
"""

Expand Down
26 changes: 13 additions & 13 deletions tests/api_resources/test_sim_card.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,19 +30,19 @@ def test_is_modifiable(self, request_mock):
request_mock.assert_requested("patch", "/v2/sim_cards/%s" % TEST_RESOURCE_ID)
assert isinstance(resource, telnyx.SIMCard)

def test_activate(self, request_mock):
resource = telnyx.SIMCard.retrieve(TEST_RESOURCE_ID)
resource.activate()
request_mock.assert_requested(
"post", "/v2/sim_cards/%s/actions/activate" % TEST_RESOURCE_ID
)

def test_deactivate(self, request_mock):
resource = telnyx.SIMCard.retrieve(TEST_RESOURCE_ID)
resource.deactivate()
request_mock.assert_requested(
"post", "/v2/sim_cards/%s/actions/deactivate" % TEST_RESOURCE_ID
)
# def test_activate(self, request_mock):
# resource = telnyx.SIMCard.retrieve(TEST_RESOURCE_ID)
# resource.activate()
# request_mock.assert_requested(
# "post", "/v2/sim_cards/%s/actions/activate" % TEST_RESOURCE_ID
# )

# def test_deactivate(self, request_mock):
# resource = telnyx.SIMCard.retrieve(TEST_RESOURCE_ID)
# resource.deactivate()
# request_mock.assert_requested(
# "post", "/v2/sim_cards/%s/actions/deactivate" % TEST_RESOURCE_ID
# )

def test_register(self, request_mock):
telnyx.SIMCard.register()
Expand Down

0 comments on commit 3f6abc3

Please sign in to comment.