Merge branch 'master' into dev/revert_rubocop

.rubocop.yml

@@ -1,15 +1,18 @@
+inherit_from: .rubocop_todo.yml
+
 
 AllCops:
   DisplayCopNames: true
-  TargetRubyVersion: 2.0
+  TargetRubyVersion: 2.4
+  NewCops: disable
 
 Layout/CaseIndentation:
   EnforcedStyle: end
 
-Layout/IndentArray:
+Layout/FirstArrayElementIndentation:
   EnforcedStyle: consistent
 
-Layout/IndentHash:
+Layout/FirstHashElementIndentation:
   EnforcedStyle: consistent
 
 Metrics/MethodLength:
@@ -26,36 +29,3 @@ Style/FrozenStringLiteralComment:
 
 Style/StringLiterals:
   EnforcedStyle: double_quotes
-
-Style/TrailingCommaInLiteral:
-  EnforcedStyleForMultiline: consistent_comma
-
-Metrics/AbcSize:
-  Max: 52
-
-Metrics/BlockLength:
-  Max: 498
-
-Metrics/ClassLength:
-  Max: 659
-
-# Offense count: 11
-Metrics/CyclomaticComplexity:
-  Max: 15
-
-Metrics/LineLength:
-  Max: 310
-
-Metrics/ParameterLists:
-  Max: 7
-
-Metrics/PerceivedComplexity:
-  Max: 17
-
-Style/ClassVars:
-  Exclude:
-    - 'lib/telnyx/telnyx_object.rb'
-    - 'test/telnyx/api_resource_test.rb'
-
-Style/Documentation:
-  Enabled: false

.rubocop_todo.yml

@@ -0,0 +1,300 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2020-12-11 00:11:23 UTC using RuboCop version 1.6.0.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: TreatCommentsAsGroupSeparators, ConsiderPunctuation, Include.
+# Include: **/*.gemspec
+Gemspec/OrderedDependencies:
+  Exclude:
+    - 'telnyx.gemspec'
+
+# Offense count: 1
+# Configuration parameters: Include.
+# Include: **/*.gemspec
+Gemspec/RequiredRubyVersion:
+  Exclude:
+    - 'telnyx.gemspec'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyleAlignWith, Severity.
+# SupportedStylesAlignWith: start_of_line, begin
+Layout/BeginEndAlignment:
+  Exclude:
+    - 'lib/telnyx/util.rb'
+
+# Offense count: 8
+# Cop supports --auto-correct.
+Layout/EmptyLineAfterGuardClause:
+  Exclude:
+    - 'lib/telnyx.rb'
+    - 'lib/telnyx/call.rb'
+    - 'lib/telnyx/list_object.rb'
+    - 'lib/telnyx/messaging_phone_number.rb'
+    - 'lib/telnyx/singleton_api_resource.rb'
+    - 'lib/telnyx/util.rb'
+    - 'test/telnyx_mock.rb'
+
+# Offense count: 43
+# Cop supports --auto-correct.
+# Configuration parameters: AllowMultipleStyles, EnforcedHashRocketStyle, EnforcedColonStyle, EnforcedLastArgumentHashStyle.
+# SupportedHashRocketStyles: key, separator, table
+# SupportedColonStyles: key, separator, table
+# SupportedLastArgumentHashStyles: always_inspect, always_ignore, ignore_implicit, ignore_explicit
+Layout/HashAlignment:
+  Exclude:
+    - 'lib/telnyx/util.rb'
+    - 'telnyx.gemspec'
+
+# Offense count: 4
+# Cop supports --auto-correct.
+Layout/LeadingEmptyLines:
+  Exclude:
+    - 'test/telnyx/number_lookup_test.rb'
+    - 'test/telnyx/number_order_document_test.rb'
+    - 'test/telnyx/phone_number_regulatory_requirement_test.rb'
+    - 'test/telnyx/regulatory_requirement_test.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Layout/RescueEnsureAlignment:
+  Exclude:
+    - 'lib/telnyx/util.rb'
+
+# Offense count: 3
+# Configuration parameters: AllowedMethods.
+# AllowedMethods: enums
+Lint/ConstantDefinitionInBlock:
+  Exclude:
+    - 'test/telnyx/api_operations_test.rb'
+    - 'test/telnyx/telnyx_object_test.rb'
+
+# Offense count: 3
+# Configuration parameters: MaximumRangeSize.
+Lint/MissingCopEnableDirective:
+  Exclude:
+    - 'lib/telnyx/api_operations/nested_resource.rb'
+
+# Offense count: 1
+Lint/MissingSuper:
+  Exclude:
+    - 'lib/telnyx/errors.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Lint/RedundantCopDisableDirective:
+  Exclude:
+    - 'Gemfile'
+
+# Offense count: 12
+# Configuration parameters: IgnoredMethods, CountRepeatedAttributes.
+Metrics/AbcSize:
+  Max: 55
+
+# Offense count: 28
+# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods.
+# IgnoredMethods: refine
+Metrics/BlockLength:
+  Max: 372
+
+# Offense count: 10
+# Configuration parameters: CountComments, CountAsOne.
+Metrics/ClassLength:
+  Max: 495
+
+# Offense count: 5
+# Configuration parameters: IgnoredMethods.
+Metrics/CyclomaticComplexity:
+  Max: 16
+
+# Offense count: 2
+# Configuration parameters: CountKeywordArgs, MaxOptionalParameters.
+Metrics/ParameterLists:
+  Max: 6
+
+# Offense count: 5
+# Configuration parameters: IgnoredMethods.
+Metrics/PerceivedComplexity:
+  Max: 18
+
+# Offense count: 13
+# Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames.
+# AllowedNames: at, by, db, id, in, io, ip, of, on, os, pp, to
+Naming/MethodParameterName:
+  Exclude:
+    - 'lib/telnyx/errors.rb'
+    - 'lib/telnyx/list_object.rb'
+    - 'lib/telnyx/telnyx_client.rb'
+    - 'lib/telnyx/telnyx_object.rb'
+    - 'lib/telnyx/util.rb'
+
+# Offense count: 11
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: separated, grouped
+Style/AccessorGrouping:
+  Exclude:
+    - 'lib/telnyx/errors.rb'
+    - 'lib/telnyx/telnyx_client.rb'
+
+# Offense count: 4
+# Cop supports --auto-correct.
+Style/CaseLikeIf:
+  Exclude:
+    - 'lib/telnyx.rb'
+    - 'lib/telnyx/errors.rb'
+    - 'lib/telnyx/util.rb'
+
+# Offense count: 2
+Style/ClassVars:
+  Exclude:
+    - 'lib/telnyx/telnyx_object.rb'
+    - 'test/telnyx/api_resource_test.rb'
+
+# Offense count: 3
+# Cop supports --auto-correct.
+# Configuration parameters: Keywords.
+# Keywords: TODO, FIXME, OPTIMIZE, HACK, REVIEW, NOTE
+Style/CommentAnnotation:
+  Exclude:
+    - 'lib/telnyx/api_operations/save.rb'
+    - 'test/telnyx/telnyx_object_test.rb'
+    - 'test/telnyx/util_test.rb'
+
+# Offense count: 45
+Style/Documentation:
+  Enabled: false
+
+# Offense count: 2
+# Cop supports --auto-correct.
+Style/Encoding:
+  Exclude:
+    - 'test/telnyx/api_operations_test.rb'
+    - 'test/telnyx/api_resource_test.rb'
+
+# Offense count: 19
+# Cop supports --auto-correct.
+Style/ExpandPathArguments:
+  Enabled: false
+
+# Offense count: 10
+# Configuration parameters: MaxUnannotatedPlaceholdersAllowed.
+# SupportedStyles: annotated, template, unannotated
+Style/FormatStringToken:
+  EnforcedStyle: unannotated
+
+# Offense count: 3
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, UseHashRocketsWithSymbolValues, PreferHashRocketsForNonAlnumEndingSymbols.
+# SupportedStyles: ruby19, hash_rockets, no_mixed_keys, ruby19_no_mixed_keys
+Style/HashSyntax:
+  Exclude:
+    - 'test/telnyx/telnyx_object_test.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+Style/HashTransformValues:
+  Exclude:
+    - 'lib/telnyx/telnyx_object.rb'
+
+# Offense count: 8
+# Cop supports --auto-correct.
+Style/IfUnlessModifier:
+  Exclude:
+    - 'lib/telnyx.rb'
+    - 'lib/telnyx/api_operations/request.rb'
+    - 'lib/telnyx/api_operations/save.rb'
+    - 'lib/telnyx/api_resource.rb'
+    - 'lib/telnyx/singleton_api_resource.rb'
+    - 'lib/telnyx/telnyx_client.rb'
+    - 'lib/telnyx/telnyx_object.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, IgnoredMethods.
+# SupportedStyles: predicate, comparison
+Style/NumericPredicate:
+  Exclude:
+    - 'spec/**/*'
+    - 'lib/telnyx/telnyx_client.rb'
+
+# Offense count: 1
+# Configuration parameters: AllowedMethods.
+# AllowedMethods: respond_to_missing?
+Style/OptionalBooleanParameter:
+  Exclude:
+    - 'lib/telnyx/telnyx_object.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/RedundantAssignment:
+  Exclude:
+    - 'lib/telnyx/telnyx_client.rb'
+
+# Offense count: 40
+# Cop supports --auto-correct.
+Style/RedundantFreeze:
+  Enabled: false
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: ConvertCodeThatCanStartToReturnNil, AllowedMethods.
+# AllowedMethods: present?, blank?, presence, try, try!
+Style/SafeNavigation:
+  Exclude:
+    - 'lib/telnyx/telnyx_object.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+Style/StderrPuts:
+  Exclude:
+    - 'lib/telnyx/api_operations/request.rb'
+    - 'lib/telnyx/telnyx_client.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+Style/StringConcatenation:
+  Exclude:
+    - 'lib/telnyx/call.rb'
+    - 'lib/telnyx/telnyx_client.rb'
+
+# Offense count: 29
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyleForMultiline.
+# SupportedStylesForMultiline: comma, consistent_comma, no_comma
+Style/TrailingCommaInArrayLiteral:
+  Exclude:
+    - 'test/telnyx/list_object_test.rb'
+    - 'test/telnyx/number_order_test.rb'
+    - 'test/telnyx/outbound_voice_profile_test.rb'
+    - 'test/telnyx/telnyx_object_test.rb'
+    - 'test/telnyx/util_test.rb'
+    - 'test/test_data.rb'
+
+# Offense count: 68
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyleForMultiline.
+# SupportedStylesForMultiline: comma, consistent_comma, no_comma
+Style/TrailingCommaInHashLiteral:
+  Enabled: false
+
+# Offense count: 5
+# Cop supports --auto-correct.
+# Configuration parameters: WordRegex.
+# SupportedStyles: percent, brackets
+Style/WordArray:
+  EnforcedStyle: percent
+  MinSize: 4
+
+# Offense count: 21
+# Cop supports --auto-correct.
+# Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
+# URISchemes: http, https
+Layout/LineLength:
+  Max: 310