Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(WEBRTC): Video Calling with React Native support #15

Merged
merged 1 commit into from May 12, 2020
Merged

feat(WEBRTC): Video Calling with React Native support #15

merged 1 commit into from May 12, 2020

Conversation

DeividVeloso
Copy link
Contributor

@DeividVeloso DeividVeloso commented May 12, 2020 •
edited by paulsha

Changelog

  • Added support for React Native
  • Added support for Video Calls
  • Updated examples
  • Changed README instructions of use

📝 To Do

  • All linters pass
  • All tests pass
  • Change documentation based on changes

✋ Manual testing

  1. npm install in the root folder
  2. Chose an example to test
    2.1 cd examples/vanilla --> open index.html
    OR
    2.2 cd examples/react --> npm install --> npm run setup --> npm run storybook
  3. Get your production credentials in the customer portal
  4. make a call and see the video call working

🦊 Browser testing

Desktop

  • Edge (latest)
  • Chrome
  • Firefox
  • Safari

@paulsha paulsha changed the title feat(WEBRTC): upgraded code and enabled video call feat(WEBRTC): Video Calling with React Native support May 12, 2020
@DeividVeloso DeividVeloso marked this pull request as ready for review May 12, 2020 20:16
hugooliveirad
hugooliveirad reviewed May 12, 2020
View reviewed changes
LICENSE Outdated
Copyright (C) 2005-2017 Anthony Minessale II
Copyright (C) 2018 Seven Du <dujinfang@x-y-t.cn>
Copyright (C) 2018 Xueyun Jiang <jiangxueyun@x-y-t.cn>
Copyright (C) 2018 Seven Du <dujinfang@x-y-t.cn(opens in new tab)>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this correct?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed

hugooliveirad
hugooliveirad approved these changes May 12, 2020
View reviewed changes
Copy link
Contributor

@hugooliveirad hugooliveirad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming code is identical to already reviewed. License updates might need work.

@DeividVeloso DeividVeloso merged commit 99e5d75 into master May 12, 2020
@DeividVeloso DeividVeloso deleted the WEBRTC-enable-video-call branch May 12, 2020 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugooliveirad hugooliveirad hugooliveirad approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DeividVeloso @hugooliveirad