Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ENGDESK-26922): Make login_token optional #340

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Conversation

farhat-ha
Copy link
Collaborator

Creating a client no longer requires login_tokento be passed. This is to allow users to login with username and password without TypeScripts errors.

Describe your changes

πŸ“ To Do

  • All linters pass
  • All tests pass
  • Change documentation based on my changes

βœ‹ Manual testing

  1. Provide manual testing instructions

🦊 Browser testing

  1. navigate to packages/js
  2. run yarn build
  3. run yarn link
  4. go to a webrtc project and run the yarn link @telnyx/webrtc
  5. This code should not throw typecheck errors.
const client = new TelnyxRTC({
login: "login",
password: "password"
})

Desktop

  • Edge (latest)
  • Chrome
  • Firefox
  • Safari

πŸ“Έ Screenshots

Description Screenshot
Desktop
usage.gif

Creating a client no longer requires `login_token`to be passed. This is
to allow users to login with username and password without TypeScripts errors.
@farhat-ha farhat-ha merged commit 1c0b36a into main Feb 20, 2024
2 checks passed
@farhat-ha farhat-ha deleted the haythem/ENGDESK-26922 branch February 20, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants