Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ENGDESK-23349): bind telnyxids on ringing event for outbound calls #342

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

farhat-ha
Copy link
Collaborator

Describe your changes

I added code to assign telnyx ids when the ringing event is received.

Those ids are initially undefined because they are generated by the telephony engine, the ringing event is the first event that has these ids.

Help needed

I couldn't check if telnyxCallControlId is set correctly, I'm new here, not sure how to test that manually

📝 To Do

  • All linters pass
  • All tests pass
  • Change documentation based on my changes

✋ Manual testing

  1. cd into js package
  2. yarn build
  3. yarn link
  4. go to rtc-demo-2 (or any app for testing)
  5. yarn link @telnyx/webrtc
  6. initiate a call and inspect if telnyxIds are set properly

🦊 Browser testing

Desktop

  • Edge (latest)
  • Chrome
  • Firefox
  • Safari

📸 Screenshots

Description Screenshot
Desktop
Screenshot 2024-02-21 at 2 40 36 PM
   |

| usage.gif | |

@farhat-ha farhat-ha merged commit 1b1df78 into main Feb 26, 2024
2 checks passed
@farhat-ha farhat-ha deleted the haythem/ENGDESK-23349 branch February 26, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants