feat: add a faster work-around for ice gathering never completing #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farhat-ha
requested review from
a team,
DeividVeloso,
ericaprieto,
lmao12,
jonathan-telnyx and
priscillasantana
- Added calls to measure time between initiating a call and actually sending the invite - Added utility to created deferred promises and debouncing functions - Refactor Peer.ts, invite and answer calls to wait for ice gathering
farhat-ha
force-pushed
the
haythem/call_invite_perf
branch
from
8d2f93e
to
e2a782a
Compare
jonathan-telnyx
approved these changes
Apr 5, 2024
| @@ -16,7 +16,12 @@ import { | |||
| RTCPeerConnection, | |||
| streamIsValid, | |||
| } from '../util/webrtc'; | |||
| import { isFunction } from '../util/helpers'; | |||
| import { | |||
| DeferredPromise, | |||
There was a problem hiding this comment.
I think that DeferredPromise is not being used, just deferredPromise is
There was a problem hiding this comment.
Its just used as a type here, but i noticed debounce in the next line was left unused after refactoring. Thanks for the catch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XXXX-YYY
Describe your changes
📝 To Do
✋ Manual testing
🦊 Browser testing
Desktop
📸 Screenshots