-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Configuration of Full-Text Target Precedence for SFX #52
Conversation
Hey @kevinreiss , thanks, can you explain what you mean by the doc: "Multiple matching targets will be displayed in alpha order." I don't understand how there could be multiple matching targets (matching what?), or alphabetical by what? |
Okay, I refactored, supports terminating wildcards now. I also changed the name of the config from Feel free to take a look if have feedback on anything I've done. But looking pretty good, I think. Thanks for getting this going. |
"Multiple matching targets will be displayed in alpha order." I should have actually removed that comment since the sort order was changed to explicitly follow whatever was sunk in the preferred/sunk variables. All your updates look good to me and I agree that |
Cool, I'm also going to put the reordering before the roll_up_prefixes, so you can effect what target gets kept when rolled out by making it first, if you want. I don't think there's any reason one would need the reordering to be after the rollup? |
…onfiguring in under @preferred_targets or @sunk_targets.
e3ae8ea
to
fce94b3
Compare
No, that makes sense, especially with the wildcard support. Originally I On Wed, Mar 25, 2015 at 10:15 AM, Jonathan Rochkind <
|
Support Configuration of Full-Text Target Precedence for SFX
Add feature to either prefer or sink SFX full-text targets based on values configured in umlaut_services.yml under @preferred_targets or @sunk_targets. Currently supports on full target strings, so PROQUEST_NEW_AWESOME_PLATFORM works but PROQUEST_ does not. These rules fire after any configured target roll ups.