Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Configuration of Full-Text Target Precedence for SFX #52

Merged
merged 8 commits into from
Mar 25, 2015

Conversation

kevinreiss
Copy link
Contributor

Add feature to either prefer or sink SFX full-text targets based on values configured in umlaut_services.yml under @preferred_targets or @sunk_targets. Currently supports on full target strings, so PROQUEST_NEW_AWESOME_PLATFORM works but PROQUEST_ does not. These rules fire after any configured target roll ups.

@jrochkind
Copy link
Member

Hey @kevinreiss , thanks, can you explain what you mean by the doc: "Multiple matching targets will be displayed in alpha order." I don't understand how there could be multiple matching targets (matching what?), or alphabetical by what?

@jrochkind
Copy link
Member

Okay, I refactored, supports terminating wildcards now. I also changed the name of the config from preferred_targets to boosted_targets. Although I wonder if it should really be boost_targets and sink_targets, verbs.

Feel free to take a look if have feedback on anything I've done. But looking pretty good, I think. Thanks for getting this going.

@kevinreiss
Copy link
Contributor Author

"Multiple matching targets will be displayed in alpha order." I should have actually removed that comment since the sort order was changed to explicitly follow whatever was sunk in the preferred/sunk variables. All your updates look good to me and I agree that boost_targets is a better name than boosted_targets, especially since you've added support for wildcards.

@jrochkind
Copy link
Member

Cool, I'm also going to put the reordering before the roll_up_prefixes, so you can effect what target gets kept when rolled out by making it first, if you want. I don't think there's any reason one would need the reordering to be after the rollup?

@kevinreiss
Copy link
Contributor Author

No, that makes sense, especially with the wildcard support. Originally I
thought it would be better to happen after because any rolled up targets
would already be gone.

On Wed, Mar 25, 2015 at 10:15 AM, Jonathan Rochkind <
notifications@github.com> wrote:

Cool, I'm also going to put the reordering before the roll_up_prefixes,
so you can effect what target gets kept when rolled out by making it first,
if you want. I don't think there's any reason one would need the reordering
to be after the rollup?


Reply to this email directly or view it on GitHub
#52 (comment).

jrochkind added a commit that referenced this pull request Mar 25, 2015
Support Configuration of Full-Text Target Precedence for SFX
@jrochkind jrochkind merged commit d0239e7 into master Mar 25, 2015
@jrochkind jrochkind deleted the sfx_target_ordering branch March 25, 2015 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants