Optionally fail test if launch-file fails #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LoyVanBeek
force-pushed
the
feature/test_require_launch_file_success
branch
from
76881b6
to
235faf5
Compare
LoyVanBeek
force-pushed
the
feature/test_require_launch_file_success
branch
2 times, most recently
from
f6a4758
to
235faf5
Compare
|
I've force-pushed this branch a couple of times, now back to target |
|
Looks good to me and is definitely useful, thanks for adding! Now that #129 should be fixed, do you think this can be merged to develop? |
|
Yes, have verified again. I found a weird case where the process that would check the state's side-effects did not exit ever and thus never produced a result. That is fixed in my use-case, FlexBE did not need a change, so it's good to merge.
|
If the launch-file in a FlexBE test fails, signal this to the TestContext that can then optionally fail due to this This allows to run scripts etc to verify State/Behavior side effects
And check they exit code to decide success/fail of launch file
LoyVanBeek
force-pushed
the
feature/test_require_launch_file_success
branch
from
47caf62
to
d2cd790
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the launch-file in a FlexBE test fails, signal this to the TestContext that can then optionally fail due to this
This allows to run scripts etc to verify State/Behavior side effects
This is handy when combined with eg. https://github.com/ipa320/cob_command_tools/tree/indigo_dev/scenario_test_tools but simpler scripts as well of course.
Together, this implements
from #93