Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail test if provided test-yaml-file does not exist #94

Merged

Conversation

LoyVanBeek
Copy link
Contributor

@LoyVanBeek LoyVanBeek commented Dec 19, 2019

There is no way to know which arguments to testing_node are intended to be filenames, so best we can do is guess...

When a file is missing, there is also some test-output generated telling which file is missing.

There is no way to know which arguments are intended to be filenames, so best we can do is guess?
@LoyVanBeek LoyVanBeek marked this pull request as ready for review December 19, 2019 11:42
@pschillinger
Copy link
Member

Thanks for adding, looks good!

FYI, I started a refactoring of flexbe_testing some time ago so that I can add tests for behaviors as well, in case you would like to give some further thoughts:
https://github.com/team-vigir/flexbe_behavior_engine/tree/feature/test_behaviors/flexbe_testing

@pschillinger pschillinger merged commit d83603e into team-vigir:develop Dec 27, 2019
@LoyVanBeek LoyVanBeek deleted the feature/check_missing_testfile branch December 30, 2019 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants