Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix screen share prompt absence #117

Merged
merged 3 commits into from
Sep 2, 2022
Merged

Fix screen share prompt absence #117

merged 3 commits into from
Sep 2, 2022

Conversation

SleepySquash
Copy link
Contributor

@SleepySquash SleepySquash commented Sep 2, 2022 •
edited
Loading

Related to #79

Synopsis

#79 fixed the camera not enabling, but not the screen share prompt.

Solution

This PR fixes missing screen share prompt when no members are in the call.

Checklist

  • Created PR:
    • In draft mode
    • Name contains issue reference
    • Has type and k:: labels applied
  • Before review:
    • Documentation is updated (if required)
    • Tests are updated (if required)
    • Changes conform code style
    • CHANGELOG entry is added (if required)
    • FCM (final commit message) is posted or updated
    • Draft mode is removed
  • Review is completed and changes are approved
    • FCM (final commit message) is approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • All temporary labels are removed

@SleepySquash SleepySquash added enhancement Improvement of existing features or bugfix k::UI/UX UI (user interface) and UX (user experience) changes labels Sep 2, 2022
@SleepySquash SleepySquash added this to the 0.1.0-alpha.6 milestone Sep 2, 2022
@SleepySquash SleepySquash self-assigned this Sep 2, 2022
@SleepySquash
Copy link
Contributor Author

FCM

Fix screen share not enabling in empty `Call` (#117)

@SleepySquash SleepySquash marked this pull request as ready for review September 2, 2022 08:39
@SleepySquash SleepySquash merged commit 960a804 into main Sep 2, 2022
@SleepySquash SleepySquash deleted the fix-screen-share-prompt-absence branch September 2, 2022 08:43
github-actions bot added a commit that referenced this pull request Sep 2, 2022
@github-actions
Fix screen share not enabling in empty Call (#117) 960a804
b0e2eae
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@SleepySquash SleepySquash

Labels
enhancement Improvement of existing features or bugfix k::UI/UX UI (user interface) and UX (user experience) changes
Projects
None yet
Milestone
0.1.0-alpha.6
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@SleepySquash