Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add HomeView background setting and displaying (#123) #129

Merged
merged 21 commits into from
Sep 26, 2022
Merged

Add HomeView background setting and displaying (#123) #129

merged 21 commits into from
Sep 26, 2022

Conversation

ArturRubets
Copy link
Contributor

@ArturRubets ArturRubets commented Sep 12, 2022 •
edited by SleepySquash
Loading

Resolves #123

Synopsis

На домашней странице используется стандартный задний фон. Сделать изменения фона.

Solution

Перенести с new-design-preview сохранение и удаление заднего фона на странице персонализации (её тоже нужно перенести), плюс использование этого фона на всех страницах. Для этого нужно делать страницы прозрачными, в связи с чем нужно исправить баги, когда под страницей рисуется другая страница при анимации переключения страниц. Тут, возможно, стоит создать свою анимацию. При этом свайп слева направо обязательно должен присутствовать на всех ОС, кроме андройда (там анимация переключения страниц другая).

Checklist

  • Created PR:
    • In draft mode
    • Name contains issue reference
    • Has type and k:: labels applied
  • Before review:
    • Documentation is updated (if required)
    • Tests are updated (if required)
    • Changes conform code style
    • CHANGELOG entry is added (if required)
    • FCM (final commit message) is posted or updated
    • Draft mode is removed
  • Review is completed and changes are approved
    • FCM (final commit message) is approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • All temporary labels are removed

@ArturRubets ArturRubets added enhancement Improvement of existing features or bugfix k::refactor Refactor changes of existing code labels Sep 12, 2022
@ArturRubets ArturRubets added this to the 0.1.0-alpha.6 milestone Sep 12, 2022
@ArturRubets ArturRubets self-assigned this Sep 12, 2022
@ArturRubets
Copy link
Contributor Author

FCM

Add `HomeView` background setting and displaying (#129, #123)

@ArturRubets ArturRubets marked this pull request as ready for review September 13, 2022 06:18
SleepySquash
SleepySquash requested changes Sep 13, 2022
View reviewed changes
Copy link
Contributor

@SleepySquash SleepySquash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ArturRubets

lib/domain/repository/settings.dart Outdated Show resolved Hide resolved
lib/routes.dart Show resolved Hide resolved
lib/store/settings.dart Outdated Show resolved Hide resolved
lib/ui/page/home/page/chat/controller.dart Outdated Show resolved Hide resolved
lib/ui/page/home/page/personalization/controller.dart Outdated Show resolved Hide resolved
lib/ui/page/home/router.dart Outdated Show resolved Hide resolved
lib/ui/page/home/view.dart Outdated Show resolved Hide resolved
lib/ui/page/home/view.dart Outdated Show resolved Hide resolved
test/unit/call_test.dart Outdated Show resolved Hide resolved
lib/ui/page/home/router.dart Outdated Show resolved Hide resolved
@SleepySquash SleepySquash marked this pull request as draft September 13, 2022 11:20
@ArturRubets ArturRubets marked this pull request as ready for review September 14, 2022 13:14
SleepySquash
SleepySquash requested changes Sep 15, 2022
View reviewed changes
Copy link
Contributor

@SleepySquash SleepySquash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ArturRubets, dartdoc и unit тесты падают на CI, почините, пожалуйста.

@SleepySquash SleepySquash marked this pull request as draft September 15, 2022 16:00
@ArturRubets ArturRubets marked this pull request as ready for review September 19, 2022 05:22
SleepySquash
SleepySquash requested changes Sep 19, 2022
View reviewed changes
test/widget/auth_test.dart Outdated Show resolved Hide resolved
lib/ui/page/home/router.dart Outdated Show resolved Hide resolved
lib/ui/page/home/view.dart Outdated Show resolved Hide resolved
@SleepySquash SleepySquash marked this pull request as draft September 19, 2022 09:28
@ArturRubets ArturRubets marked this pull request as ready for review September 20, 2022 12:16
SleepySquash
SleepySquash requested changes Sep 22, 2022
View reviewed changes
Copy link
Contributor

@SleepySquash SleepySquash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ArturRubets, несколько небольших вопросов, в остальном LGTM.

lib/ui/page/home/page/personalization/controller.dart Outdated Show resolved Hide resolved
lib/ui/page/home/page/personalization/controller.dart Outdated Show resolved Hide resolved
lib/ui/page/home/page/personalization/view.dart Outdated Show resolved Hide resolved
lib/ui/page/home/page/personalization/view.dart Outdated Show resolved Hide resolved
lib/ui/page/home/page/personalization/view.dart Outdated Show resolved Hide resolved
lib/ui/page/home/router.dart Outdated Show resolved Hide resolved
lib/ui/page/home/router.dart Show resolved Hide resolved
lib/ui/page/home/view.dart Outdated Show resolved Hide resolved
@SleepySquash SleepySquash marked this pull request as draft September 22, 2022 12:04
@ArturRubets ArturRubets marked this pull request as ready for review September 23, 2022 14:01
@SleepySquash SleepySquash added the k::UI/UX UI (user interface) and UX (user experience) changes label Sep 26, 2022
@SleepySquash SleepySquash merged commit 7d50451 into main Sep 26, 2022
@SleepySquash SleepySquash deleted the 123-add-homeView-background-setting-and-displaying branch September 26, 2022 11:07
github-actions bot added a commit that referenced this pull request Sep 26, 2022
@github-actions
Add HomeView background setting and displaying (#129, #123) 7d50451
f5bd2e9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SleepySquash SleepySquash SleepySquash approved these changes

Assignees

@ArturRubets ArturRubets

Labels
enhancement Improvement of existing features or bugfix k::refactor Refactor changes of existing code k::UI/UX UI (user interface) and UX (user experience) changes
Projects
None yet
Milestone
0.1.0-alpha.6
Development

Successfully merging this pull request may close these issues.

Add HomeView background setting and displaying
2 participants
@ArturRubets @SleepySquash