Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group creation overlay has no avatars (#2) #15

Merged
merged 25 commits into from
Jun 30, 2022

Conversation

andrigel
Copy link
Contributor

@andrigel andrigel commented Jun 22, 2022

Resolves #2

Synopsis

В интерфейсе создания группы у участников почему-то нет аватаров.

Solution

Отобразить аватары пользователей, которые находятся в контактах при создании групового чата

Checklist

  • Created PR:
    • In draft mode
    • Name contains issue reference
    • Has type and k:: labels applied
  • Before review:
    • Documentation is updated (if required)
    • Tests are updated (if required)
    • Changes conform code style
    • CHANGELOG entry is added (if required)
    • FCM (final commit message) is posted or updated
    • Draft mode is removed
  • Review is completed and changes are approved
    • FCM (final commit message) is approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • All temporary labels are removed

@andrigel andrigel self-assigned this Jun 22, 2022
@andrigel andrigel added k::UI/UX UI (user interface) and UX (user experience) changes bug Bugs and incorrectness problems labels Jun 22, 2022
@andrigel andrigel added this to the 0.1.0-alpha.6 milestone Jun 22, 2022
@andrigel andrigel marked this pull request as draft June 22, 2022 10:36
@andrigel andrigel changed the title 2 group creation overlay has no avatars 2 group creation overlay has no avatars (#2) Jun 22, 2022
@andrigel andrigel added enhancement Improvement of existing features or bugfix and removed bug Bugs and incorrectness problems labels Jun 22, 2022
@andrigel
Copy link
Contributor Author

andrigel commented Jun 23, 2022

FCM

Fix missing `Avatar`s in `CreateGroup` popup (#15, #2)

- impl `RxChatContact` with reactive `User` field
- refactor `Contact`s store to include `RxChatContact`
- refactor code to use `RxChatContact`s instead of `ChatContact`s

@andrigel andrigel marked this pull request as ready for review June 23, 2022 09:56
Copy link
Contributor

@SleepySquash SleepySquash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrigel в целом рад, что проблем при создании RxChatContact сущности не появилось. Из основного просьба порефакторить сам HiveRxChatContact, т.к. он должен реактивно подхватывать и обновлять своего юзера сам (и только при реальном изменении этого юзера в контакте).

И много-много мелочей, большинство из невнимательности. По этому поводу очень-очень-очень настоятельно прошу серьёзно вычитывать задачу перед отправкой на ревью, чтобы не тратить ни моё, ни собственное время на такие мелочи.

И просьба пробежаться по коду внимательно. Некоторые вещи повторяются, я не стал их везде тыкать.

lib/domain/repository/contact.dart Outdated Show resolved Hide resolved
lib/store/contact_rx.dart Outdated Show resolved Hide resolved
lib/store/contact_rx.dart Outdated Show resolved Hide resolved
lib/store/contact.dart Outdated Show resolved Hide resolved
lib/ui/page/call/add_dialog_member/view.dart Outdated Show resolved Hide resolved
lib/ui/page/home/tab/chats/create_group/controller.dart Outdated Show resolved Hide resolved
lib/ui/page/home/tab/contacts/controller.dart Outdated Show resolved Hide resolved
lib/ui/page/home/tab/contacts/view.dart Outdated Show resolved Hide resolved
lib/ui/page/home/tab/contacts/view.dart Outdated Show resolved Hide resolved
lib/domain/repository/contact.dart Outdated Show resolved Hide resolved
@SleepySquash SleepySquash marked this pull request as draft June 24, 2022 09:00
@andrigel andrigel marked this pull request as ready for review June 26, 2022 17:27
Copy link
Contributor

@SleepySquash SleepySquash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrigel комментарии отписал, просьба ознакомиться (и если что-то не так или есть вопросы, то отписать). Поправить просьба следующий момент - хочется contact_rx обновлять один-в-один по аналогии с chat_rx, добавить воркера, чтобы не плодить реализации. В остальном всё ок 👍

lib/domain/repository/contact.dart Outdated Show resolved Hide resolved
lib/store/contact_rx.dart Outdated Show resolved Hide resolved
lib/store/contact.dart Outdated Show resolved Hide resolved
lib/store/contact_rx.dart Show resolved Hide resolved
lib/store/contact_rx.dart Outdated Show resolved Hide resolved
@SleepySquash SleepySquash marked this pull request as draft June 27, 2022 09:18
@andrigel andrigel marked this pull request as ready for review June 27, 2022 12:41
Copy link
Contributor

@SleepySquash SleepySquash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrigel есть неприятный баг.

lib/store/contact_rx.dart Outdated Show resolved Hide resolved
lib/store/contact_rx.dart Outdated Show resolved Hide resolved
lib/store/contact_rx.dart Outdated Show resolved Hide resolved
lib/store/contact_rx.dart Show resolved Hide resolved
@SleepySquash SleepySquash marked this pull request as draft June 28, 2022 09:13
@andrigel andrigel marked this pull request as ready for review June 28, 2022 13:59
@andrigel andrigel changed the title 2 group creation overlay has no avatars (#2) Group creation overlay has no avatars (#2) Jun 29, 2022
@SleepySquash SleepySquash added the k::refactor Refactor changes of existing code label Jun 30, 2022
@tyranron tyranron enabled auto-merge (squash) June 30, 2022 15:20
@tyranron tyranron merged commit 78fe572 into main Jun 30, 2022
@tyranron tyranron deleted the 2-group-creation-overlay-has-no-avatars branch June 30, 2022 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement of existing features or bugfix k::refactor Refactor changes of existing code k::UI/UX UI (user interface) and UX (user experience) changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Group creation overlay has no avatars
3 participants