Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scale down dragged Participants in Call (#190) #191

Merged
merged 16 commits into from
Nov 7, 2022
Merged

Scale down dragged Participants in Call (#190) #191

merged 16 commits into from
Nov 7, 2022

Conversation

krida2000
Copy link
Contributor

@krida2000 krida2000 commented Oct 28, 2022 •
edited by SleepySquash
Loading

Resolves #190

Synopsis

Есть участников в звонке немного (1-2 в основном виде), то перетягиваются огромные оригинальные фреймы, из-за чего место, куда эти участники перетягиваются, совершенно не видно. Это громоздко и непрактично.

Solution

Уменьшать участников при перетягивании до какого-то размера.

Checklist

  • Created PR:
    • In draft mode
    • Name contains issue reference
    • Has type and k:: labels applied
  • Before review:
    • Documentation is updated (if required)
    • Tests are updated (if required)
    • Changes conform code style
    • CHANGELOG entry is added (if required)
    • FCM (final commit message) is posted or updated
    • Draft mode is removed
  • Review is completed and changes are approved
    • FCM (final commit message) is approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • All temporary labels are removed

@krida2000 krida2000 self-assigned this Oct 28, 2022
@krida2000 krida2000 added enhancement Improvement of existing features or bugfix k::UI/UX UI (user interface) and UX (user experience) changes labels Oct 28, 2022
@krida2000 krida2000 added this to the 0.1.0-alpha.8 milestone Oct 28, 2022
@krida2000
Copy link
Contributor Author

krida2000 commented Nov 2, 2022 •
edited by SleepySquash
Loading

FCM

Scale down `Participant`s in `Call` when dragging (#191, #190)

@SleepySquash SleepySquash marked this pull request as ready for review November 2, 2022 10:37
SleepySquash
SleepySquash requested changes Nov 4, 2022
View reviewed changes
Copy link
Contributor

@SleepySquash SleepySquash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krida2000, добавьте, пожалуйста: когда у участника нет видео, но есть обложка (непустой аватар), то участник должен уменьшаться.

@SleepySquash SleepySquash merged commit cba6b7b into main Nov 7, 2022
@SleepySquash SleepySquash deleted the 190-scale-down-dragged-participant branch November 7, 2022 11:47
github-actions bot added a commit that referenced this pull request Nov 7, 2022
@github-actions
Scale down Participants in Call when dragging (#191, #190) cba6b7b
e253cf8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SleepySquash SleepySquash SleepySquash approved these changes

Assignees

@krida2000 krida2000

Labels
enhancement Improvement of existing features or bugfix k::UI/UX UI (user interface) and UX (user experience) changes
Projects
None yet
Milestone
0.1.0-alpha.8
Development

Successfully merging this pull request may close these issues.

Scale down dragged Participants in Call
2 participants
@krida2000 @SleepySquash