Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement favorite chat contacts (#223) #237

Merged
merged 15 commits into from
Dec 13, 2022
Merged

Implement favorite chat contacts (#223) #237

merged 15 commits into from
Dec 13, 2022

Conversation

merlettoth
Copy link
Contributor

@merlettoth merlettoth commented Dec 6, 2022 •
edited by SleepySquash
Loading

Resolves #223

Synopsis

Контакты можно добавлять в избранное.

Solution

Добавить возможность добавлять контакты в избранное и удалять из избранного

Checklist

  • Created PR:
    • In draft mode
    • Name contains issue reference
    • Has type and k:: labels applied
  • Before review:
    • Documentation is updated (if required)
    • Tests are updated (if required)
    • Changes conform code style
    • CHANGELOG entry is added (if required)
    • FCM (final commit message) is posted or updated
    • Draft mode is removed
  • Review is completed and changes are approved
    • FCM (final commit message) is approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • All temporary labels are removed

@merlettoth merlettoth added enhancement Improvement of existing features or bugfix feature New feature or request k::UI/UX UI (user interface) and UX (user experience) changes k::refactor Refactor changes of existing code labels Dec 6, 2022
@merlettoth merlettoth added this to the 0.1.0-alpha.8 milestone Dec 6, 2022
@merlettoth
Copy link
Contributor Author

merlettoth commented Dec 6, 2022 •
edited by SleepySquash
Loading

FCM

Implement favorite `ChatContact`s (#237, #223)

- add `folded` indicator to `ContactTile`
- impl adding and removing `ChatContact`s from favorites

@merlettoth merlettoth marked this pull request as ready for review December 6, 2022 14:42
SleepySquash
SleepySquash requested changes Dec 8, 2022
View reviewed changes
lib/ui/page/home/widget/contact_tile.dart Outdated Show resolved Hide resolved
lib/ui/page/home/widget/contact_tile.dart Outdated Show resolved Hide resolved
lib/ui/page/home/widget/contact_tile.dart Show resolved Hide resolved
lib/ui/page/home/tab/contacts/view.dart Outdated Show resolved Hide resolved
test/e2e/features/contact/favorite/.feature Outdated Show resolved Hide resolved
test/e2e/steps/has_contact.dart Outdated Show resolved Hide resolved
test/e2e/steps/has_contact.dart Outdated Show resolved Hide resolved
test/e2e/steps/has_contact.dart Outdated Show resolved Hide resolved
test/widget/contact_rename_test.dart Outdated Show resolved Hide resolved
@SleepySquash SleepySquash marked this pull request as draft December 8, 2022 10:06
@merlettoth merlettoth marked this pull request as ready for review December 12, 2022 12:38
SleepySquash
SleepySquash approved these changes Dec 13, 2022
View reviewed changes
lib/ui/page/home/widget/contact_tile.dart Outdated Show resolved Hide resolved
@SleepySquash SleepySquash enabled auto-merge (squash) December 13, 2022 11:12
@SleepySquash SleepySquash merged commit b88fba4 into main Dec 13, 2022
@SleepySquash SleepySquash deleted the 223-implement-favorite-chat-contacts branch December 13, 2022 12:46
github-actions bot added a commit that referenced this pull request Dec 13, 2022
@github-actions
Implement favorite ChatContacts (#237, #223)
f2113fd 
- add `folded` indicator to `ContactTile`
- impl adding and removing `ChatContact`s from favorites b88fba4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SleepySquash SleepySquash SleepySquash approved these changes

Assignees

@merlettoth merlettoth

Labels
enhancement Improvement of existing features or bugfix feature New feature or request k::refactor Refactor changes of existing code k::UI/UX UI (user interface) and UX (user experience) changes
Projects
None yet
Milestone
0.1.0-alpha.8
Development

Successfully merging this pull request may close these issues.

Favorite ChatContacts
2 participants
@merlettoth @SleepySquash