Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesign Auth page #29

Merged
merged 28 commits into from
Jul 29, 2022
Merged

Redesign Auth page #29

merged 28 commits into from
Jul 29, 2022

Conversation

andrigel
Copy link
Contributor

@andrigel andrigel commented Jul 6, 2022 •
edited by tyranron
Loading

Synopsis

Был сверстан новый дизайн страницы авторизации.

Solution

Нужно перенести изменения затрагивающие дизайн страницы авторизации, протестировать и вычитать их.

Checklist

  • Created PR:
    • In draft mode
    • Name contains issue reference
    • Has type and k:: labels applied
  • Before review:
    • Documentation is updated (if required)
    • Tests are updated (if required)
    • Changes conform code style
    • CHANGELOG entry is added (if required)
    • FCM (final commit message) is posted or updated
    • Draft mode is removed
  • Review is completed and changes are approved
    • FCM (final commit message) is approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • All temporary labels are removed

@andrigel andrigel marked this pull request as draft July 6, 2022 15:09
@andrigel andrigel self-assigned this Jul 7, 2022
@andrigel andrigel added enhancement Improvement of existing features or bugfix k::design Changes of application architecture and implementation design labels Jul 7, 2022
@andrigel andrigel added this to the 0.1.0-alpha.6 milestone Jul 7, 2022
@andrigel
Copy link
Contributor Author

andrigel commented Jul 7, 2022 •
edited by SleepySquash
Loading

FCM

Redesign `Auth` page (#29)

- impl `Selector` and refactor `Language` selection to use it

@andrigel andrigel marked this pull request as ready for review July 7, 2022 08:57
@SleepySquash SleepySquash changed the title New auth page design Redesign Auth page Jul 7, 2022
@SleepySquash SleepySquash added k::UI/UX UI (user interface) and UX (user experience) changes and removed k::design Changes of application architecture and implementation design labels Jul 7, 2022
SleepySquash
SleepySquash requested changes Jul 7, 2022
View reviewed changes
Copy link
Contributor

@SleepySquash SleepySquash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrigel, просьба вынести выбор языка в отдельную сущность (скорее всего, view + controller + статический метод show с параметрами типа ключика, куда разместить десктоп попап). И, если получится, хотелось бы универсализировать этот попап, сделав из него "селектор" указанных величин. Могу представить, что мы переиспользуем этот селектор/дропдаун в других местах - например, при выборе статуса в профиле. Тогда будет удобно иметь такой вот компонент.

lib/ui/page/auth/controller.dart Outdated Show resolved Hide resolved
lib/ui/page/auth/view.dart Outdated Show resolved Hide resolved
@SleepySquash SleepySquash marked this pull request as draft July 7, 2022 12:24
@SleepySquash
Copy link
Contributor

SleepySquash commented Jul 8, 2022 •
edited
Loading

@andrigel, и дизайны страниц не совпадают ведь:
Снимок экрана 2022-07-08 в 11 41 10
Снимок экрана 2022-07-08 в 11 42 26

@andrigel andrigel marked this pull request as ready for review July 14, 2022 06:58
@andrigel
Copy link
Contributor Author

@SleepySquash извиняюсь, я в последний момент менял td->l10n, исправил

@andrigel andrigel marked this pull request as ready for review July 19, 2022 09:26
SleepySquash
SleepySquash requested changes Jul 19, 2022
View reviewed changes
Copy link
Contributor

@SleepySquash SleepySquash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrigel, просьба привести Selector в порядок

CHANGELOG.md Outdated Show resolved Hide resolved
lib/ui/page/auth/view.dart Outdated Show resolved Hide resolved
lib/ui/widget/selector/controller.dart Outdated Show resolved Hide resolved
lib/ui/widget/selector/view.dart Outdated Show resolved Hide resolved
@SleepySquash SleepySquash marked this pull request as draft July 19, 2022 12:11
@andrigel andrigel marked this pull request as ready for review July 20, 2022 14:56
SleepySquash
SleepySquash requested changes Jul 21, 2022
View reviewed changes
Copy link
Contributor

@SleepySquash SleepySquash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrigel ну зочем так невнимательно(

CHANGELOG.md Outdated Show resolved Hide resolved
lib/ui/page/auth/view.dart Outdated Show resolved Hide resolved
lib/ui/widget/selector.dart Outdated Show resolved Hide resolved
lib/ui/widget/selector.dart Outdated Show resolved Hide resolved
lib/ui/widget/selector.dart Outdated Show resolved Hide resolved
lib/ui/widget/selector.dart Outdated Show resolved Hide resolved
@SleepySquash SleepySquash marked this pull request as draft July 21, 2022 08:15
@andrigel andrigel marked this pull request as ready for review July 21, 2022 09:24
@SleepySquash SleepySquash added the k::refactor Refactor changes of existing code label Jul 22, 2022
@tyranron tyranron merged commit 44ed645 into main Jul 29, 2022
@tyranron tyranron deleted the auth-page-design branch July 29, 2022 10:16
github-actions bot added a commit that referenced this pull request Jul 29, 2022
@github-actions
Redesign Auth page (#29)
ef90945 
- impl `Selector` and refactor `Language` selection to use it

Co-authored-by: SleepySquash <NordNikita@icloud.com> 44ed645
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyranron tyranron tyranron approved these changes

@SleepySquash SleepySquash SleepySquash approved these changes

Assignees

@andrigel andrigel

Labels
enhancement Improvement of existing features or bugfix k::refactor Refactor changes of existing code k::UI/UX UI (user interface) and UX (user experience) changes
Projects
None yet
Milestone
0.1.0-alpha.6
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andrigel @SleepySquash @tyranron