Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add search exiting on escape presses (#299) #310

Merged
merged 2 commits into from
Jan 10, 2023
Merged

Add search exiting on escape presses (#299) #310

merged 2 commits into from
Jan 10, 2023

Conversation

merlettoth
Copy link
Contributor

@merlettoth merlettoth commented Jan 9, 2023 •
edited by SleepySquash
Loading

Resolves #299

Synopsis

На вкладке чатов и на вкладке контактов есть поиск. Хочется добавить выход из режима поиска по нажатию эскейпа на клавиатуре.

Solution

Добавить выход из режима поиска по нажатию на эскейп.

Checklist

  • Created PR:
    • In draft mode
    • Name contains issue reference
    • Has type and k:: labels applied
  • Before review:
    • Documentation is updated (if required)
    • Tests are updated (if required)
    • Changes conform code style
    • CHANGELOG entry is added (if required)
    • FCM (final commit message) is posted or updated
    • Draft mode is removed
  • Review is completed and changes are approved
    • FCM (final commit message) is approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • All temporary labels are removed

@merlettoth merlettoth added enhancement Improvement of existing features or bugfix k::UI/UX UI (user interface) and UX (user experience) changes labels Jan 9, 2023
@merlettoth merlettoth added this to the 0.1.0-alpha.8 milestone Jan 9, 2023
@merlettoth merlettoth self-assigned this Jan 9, 2023
@merlettoth
Copy link
Contributor Author

merlettoth commented Jan 9, 2023 •
edited by SleepySquash
Loading

FCM

Implement exiting search on escape presses (#310, #299)

@merlettoth merlettoth marked this pull request as ready for review January 9, 2023 17:36
@SleepySquash SleepySquash enabled auto-merge (squash) January 10, 2023 08:55
@SleepySquash SleepySquash merged commit 87f58cc into main Jan 10, 2023
@SleepySquash SleepySquash deleted the 299-add-search-exiting-on-escape branch January 10, 2023 09:06
github-actions bot added a commit that referenced this pull request Jan 10, 2023
@github-actions
Implement exiting search on escape presses (#310, #299) 87f58cc
195ad5e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SleepySquash SleepySquash SleepySquash approved these changes

Assignees

@merlettoth merlettoth

Labels
enhancement Improvement of existing features or bugfix k::UI/UX UI (user interface) and UX (user experience) changes
Projects
None yet
Milestone
0.1.0-alpha.8
Development

Successfully merging this pull request may close these issues.

Add search exiting on escape presses
2 participants
@merlettoth @SleepySquash