Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesign copied message popup #336

Merged
merged 14 commits into from
Feb 2, 2023
Merged

Redesign copied message popup #336

merged 14 commits into from
Feb 2, 2023

Conversation

merlettoth
Copy link
Contributor

@merlettoth merlettoth commented Jan 25, 2023 •
edited by SleepySquash
Loading

Synopsis

Плашка "Скопировано" была перевёрстана, дизайн изменился.

Solution

Перенести новый дизайн с new-design-preview. Сделать отображение плашки через OverlayEntry, а не через SnackBar.

Checklist

  • Created PR:
    • In draft mode
    • Name contains issue reference
    • Has type and k:: labels applied
  • Before review:
    • Documentation is updated (if required)
    • Tests are updated (if required)
    • Changes conform code style
    • CHANGELOG entry is added (if required)
    • FCM (final commit message) is posted or updated
    • Draft mode is removed
  • Review is completed and changes are approved
    • FCM (final commit message) is approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • All temporary labels are removed

@merlettoth merlettoth added enhancement Improvement of existing features or bugfix k::UI/UX UI (user interface) and UX (user experience) changes labels Jan 25, 2023
@merlettoth merlettoth added this to the 0.1.0-alpha.8 milestone Jan 25, 2023
@merlettoth merlettoth self-assigned this Jan 25, 2023
@merlettoth
Copy link
Contributor Author

merlettoth commented Jan 25, 2023 •
edited by SleepySquash
Loading

FCM

Redesign snackbar (#336)

- impl custom `FloatingSnackBar`

Additionally:
- fix window position not persisting when resizing
- increase Dart version constraints to 4.0.0

@merlettoth merlettoth marked this pull request as ready for review January 25, 2023 12:14
@merlettoth merlettoth marked this pull request as draft January 27, 2023 15:23
@merlettoth merlettoth marked this pull request as ready for review January 30, 2023 09:52
SleepySquash
SleepySquash requested changes Jan 31, 2023
View reviewed changes
Copy link
Contributor

@SleepySquash SleepySquash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@merlettoth, по возможности хотелось бы отказаться от прокидывания contextа в каждый MessagePopup.success, плюс порефакторить можно чуть-чуть виджет с анимашкой.

lib/util/message_popup.dart Outdated Show resolved Hide resolved
lib/ui/widget/floating_snack_bar.dart Outdated Show resolved Hide resolved
lib/ui/widget/floating_snack_bar.dart Outdated Show resolved Hide resolved
lib/util/message_popup.dart Outdated Show resolved Hide resolved
@SleepySquash SleepySquash marked this pull request as draft January 31, 2023 09:41
@merlettoth merlettoth marked this pull request as ready for review February 1, 2023 11:15
SleepySquash
SleepySquash requested changes Feb 1, 2023
View reviewed changes
lib/routes.dart Show resolved Hide resolved
lib/ui/widget/floating_snack_bar.dart Outdated Show resolved Hide resolved
@SleepySquash SleepySquash marked this pull request as draft February 1, 2023 13:37
@merlettoth merlettoth marked this pull request as ready for review February 1, 2023 18:03
SleepySquash
SleepySquash approved these changes Feb 2, 2023
View reviewed changes
lib/ui/widget/floating_snack_bar.dart Outdated Show resolved Hide resolved
lib/ui/widget/floating_snack_bar.dart Outdated Show resolved Hide resolved
@SleepySquash SleepySquash enabled auto-merge (squash) February 2, 2023 10:42
@SleepySquash SleepySquash merged commit a024191 into main Feb 2, 2023
@SleepySquash SleepySquash deleted the redesign-copied-message-popup branch February 2, 2023 11:09
github-actions bot added a commit that referenced this pull request Feb 2, 2023
@github-actions
Redesign snackbar (#336)
ddf21be 
- impl custom `FloatingSnackBar`

Additionally:
- fix window position not persisting when resizing
- increase Dart version constraints to 4.0.0 a024191
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SleepySquash SleepySquash SleepySquash approved these changes

Assignees

@merlettoth merlettoth

Labels
enhancement Improvement of existing features or bugfix k::UI/UX UI (user interface) and UX (user experience) changes
Projects
None yet
Milestone
0.1.0-alpha.8
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@merlettoth @SleepySquash