Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MyUser.unreadChatsCount badge to Windows (#327) #342

Merged
merged 12 commits into from
Feb 22, 2023

Conversation

merlettoth
Copy link
Contributor

@merlettoth merlettoth commented Feb 2, 2023

Resolves #327

Synopsis

На Android, iOS, macOS у иконки приложения есть бэйджик с количеством непрочитанных чатов. На windows нету, т.к. используемый пакет не может отрисовывать бэйджики на Windows.

Solution

Использовать для отображения бэйджиков на windows отдельный пакет windows_taskbar.

Checklist

  • Created PR:
    • In draft mode
    • Name contains issue reference
    • Has type and k:: labels applied
  • Before review:
    • Documentation is updated (if required)
    • Tests are updated (if required)
    • Changes conform code style
    • CHANGELOG entry is added (if required)
    • FCM (final commit message) is posted or updated
    • Draft mode is removed
  • Review is completed and changes are approved
    • FCM (final commit message) is approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • All temporary labels are removed

@merlettoth merlettoth added enhancement Improvement of existing features or bugfix k::UI/UX UI (user interface) and UX (user experience) changes platform::windows Specific to Windows platform labels Feb 2, 2023
@merlettoth merlettoth added this to the 0.1.0-alpha.8 milestone Feb 2, 2023
@merlettoth merlettoth self-assigned this Feb 2, 2023
@merlettoth
Copy link
Contributor Author

merlettoth commented Feb 3, 2023

FCM

Display `MyUser.unreadChatsCount` on Windows application icon (#342, #327)

@merlettoth merlettoth marked this pull request as ready for review February 3, 2023 08:05
lib/domain/service/notification.dart Outdated Show resolved Hide resolved
@SleepySquash SleepySquash marked this pull request as draft February 3, 2023 09:30
@merlettoth merlettoth marked this pull request as ready for review February 3, 2023 14:20
@SleepySquash
Copy link
Contributor

@merlettoth, LGTM, но у меня на Windows 10 иконка ни мигает вообще, цифры рисуются, а на Windows 11 вообще не работает ничего, даже цифр нет. Можете поделиться анимашкой мигания, пожалуйста, и Вашей версией Windows 10? У меня стоит 20H2.

@merlettoth
Copy link
Contributor Author

@SleepySquash , у меня Windows 10 версии 22H2. Видео сделано при работе на тестовом сервере. На продовом сервере у меня тоже нет мигания, потому что NotificationService.show() не вызывается. На тестовом сервере NotificationService.show() вызывается и мигания присутствуют.

@SleepySquash SleepySquash removed this from the 0.1.0-alpha.9 milestone Feb 22, 2023
@SleepySquash SleepySquash added this to the 0.1.0-alpha.8 milestone Feb 22, 2023
@SleepySquash SleepySquash merged commit 0594423 into main Feb 22, 2023
@SleepySquash SleepySquash deleted the 327-add-unread-chats-count-badge-to-windows branch February 22, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement of existing features or bugfix k::UI/UX UI (user interface) and UX (user experience) changes platform::windows Specific to Windows platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add MyUser.unreadChatsCount badge to Windows
2 participants