Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add time displaying modes #399

Merged
merged 31 commits into from
Apr 20, 2023
Merged

Add time displaying modes #399

merged 31 commits into from
Apr 20, 2023

Conversation

krida2000
Copy link
Contributor

@krida2000 krida2000 commented Apr 6, 2023 •
edited by SleepySquash
Loading

Synopsis

На new-design-preview появилась возможность настраивать отображение времени в чате.

Solution

Изменения будут перенесены.

Checklist

  • Created PR:
    • In draft mode
    • Name contains issue reference
    • Has type and k:: labels applied
  • Before review:
    • Documentation is updated (if required)
    • Tests are updated (if required)
    • Changes conform code style
    • CHANGELOG entry is added (if required)
    • FCM (final commit message) is posted or updated
    • Draft mode is removed
  • Review is completed and changes are approved
    • FCM (final commit message) is approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • All temporary labels are removed

@krida2000 krida2000 added feature New feature or request k::UI/UX UI (user interface) and UX (user experience) changes labels Apr 6, 2023
@krida2000 krida2000 added this to the 0.1.0-alpha.9 milestone Apr 6, 2023
@krida2000 krida2000 self-assigned this Apr 6, 2023
@krida2000
Copy link
Contributor Author

krida2000 commented Apr 7, 2023 •
edited by SleepySquash
Loading

FCM

Add timestamps to `ChatItem` and `ChatForward` widgets (#399)

- add `ApplicationSettings.timelineEnabled` switching timestamps and timeline in `Chat`
- add `ProfileTab.chats` section to `Menu` tab
- add `TimelineSwitchView` switching `ApplicationSettings.timelineEnabled`
- refactor `ChatItemWidget` and `ChatForwardWidget` to display timestamps

Additionally:
- add `RichTextExtension` finding `RichText`s

@krida2000 krida2000 marked this pull request as ready for review April 7, 2023 08:32
SleepySquash
SleepySquash requested changes Apr 11, 2023
View reviewed changes
Copy link
Contributor

@SleepySquash SleepySquash left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krida2000, гляньте, пожалуйста, по файликам тогда какое-нибудь решение отображения меток времени. И по статусам, которые Вы упомянули, что рисуются слева через 2 секунды.

@SleepySquash SleepySquash marked this pull request as draft April 11, 2023 12:35
@krida2000 krida2000 marked this pull request as ready for review April 13, 2023 07:35
SleepySquash
SleepySquash requested changes Apr 13, 2023
View reviewed changes
Copy link
Contributor

@SleepySquash SleepySquash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krida2000, подумайте, пожалуйста, над визуальной проблемкой с переносом строки. Какие-нибудь варианты исправить эту проблему, может, имеются? Можно взвесить, что хуже, а что ещё хуже, и использовать просто "хуже" вариант?

lib/ui/page/home/page/chat/widget/chat_item.dart Outdated Show resolved Hide resolved
SleepySquash
SleepySquash requested changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@SleepySquash SleepySquash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krida2000, настоятельная просьба крайне внимательно тестировать задачу и код на все возможные случаи компоновки сообщения. И на телефоне, и на компьютере желательно. И с таймлайном, и без таймлайна.

lib/ui/page/home/page/chat/widget/chat_item.dart Outdated Show resolved Hide resolved
lib/ui/page/home/page/chat/widget/chat_item.dart Show resolved Hide resolved
test/widget/chat_edit_message_test.dart Outdated Show resolved Hide resolved
@SleepySquash SleepySquash marked this pull request as draft April 17, 2023 09:14
@krida2000 krida2000 marked this pull request as ready for review April 18, 2023 13:50
@krida2000 krida2000 marked this pull request as draft April 18, 2023 13:50
@krida2000 krida2000 marked this pull request as ready for review April 19, 2023 09:49
SleepySquash
SleepySquash approved these changes Apr 19, 2023
View reviewed changes
test/extension/find.dart Outdated Show resolved Hide resolved
@SleepySquash SleepySquash added enhancement Improvement of existing features or bugfix k::refactor Refactor changes of existing code labels Apr 19, 2023
@SleepySquash SleepySquash merged commit 1a95144 into main Apr 20, 2023
@SleepySquash SleepySquash deleted the time-insite-message branch April 20, 2023 12:26
github-actions bot added a commit that referenced this pull request Apr 20, 2023
@github-actions
Add timestamps to ChatItemWidget and ChatForwardWidget (#399)
364c63a 
- add `ApplicationSettings.timelineEnabled` switching timestamps and timeline in `Chat`
- add `ProfileTab.chats` section to `Menu` tab
- add `TimelineSwitchView` switching `ApplicationSettings.timelineEnabled`
- refactor `ChatItemWidget` and `ChatForwardWidget` to display timestamps

Additionally:
- add `RichTextExtension` finding `RichText`s 1a95144
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SleepySquash SleepySquash SleepySquash approved these changes

Assignees

@krida2000 krida2000

Labels
enhancement Improvement of existing features or bugfix feature New feature or request k::refactor Refactor changes of existing code k::UI/UX UI (user interface) and UX (user experience) changes
Projects
No open projects
Way to 0.1.0-alpha.9
Status: Done
Milestone
0.1.0-alpha.9
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@krida2000 @SleepySquash