Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GestureDetector drag down on mobile call (#44) #45

Merged
merged 13 commits into from
Jul 27, 2022

Conversation

krida2000
Copy link
Contributor

@krida2000 krida2000 commented Jul 25, 2022

Resolves #44

Synopsis

В мобильном звонке жест "свайп вниз" сразу же активирует минимизацию звонка в окошко. Этот жест происходит сразу и малейшее изменение положения курсора/пальца на 1 пиксель вниз приводит к этому поведению. Это сильно некорректно, когда пальцем пытаешься просто задержать какое-либо видео, чтобы начать его сортировку, палец не может находиться на одной точке, он постоянно чуть-чуть перемещается туда-сюда. Нужно ввести какую-то область, в пределах которой жест "свайп вниз" не должен распознаваться. И если палец будет проведён за эту область, то жест считать успешно распознанным.

Solution

Стоит изучить то, как работают GestureRecognizerы на Flutterе и реализовать свой распознаватель с учётом этого поведения.

Checklist

  • Created PR:
    • In draft mode
    • Name contains issue reference
    • Has type and k:: labels applied
  • Before review:
    • Documentation is updated (if required)
    • Tests are updated (if required)
    • Changes conform code style
    • CHANGELOG entry is added (if required)
    • FCM (final commit message) is posted or updated
    • Draft mode is removed
  • Review is completed and changes are approved
    • FCM (final commit message) is approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • All temporary labels are removed

@krida2000 krida2000 added enhancement Improvement of existing features or bugfix k::UI/UX UI (user interface) and UX (user experience) changes labels Jul 25, 2022
@krida2000 krida2000 added this to the 0.1.0-alpha.6 milestone Jul 25, 2022
@krida2000 krida2000 self-assigned this Jul 25, 2022
@krida2000
Copy link
Contributor Author

krida2000 commented Jul 25, 2022

FCM

Fix mobile `Call` minimization gesture being too rapid (#45, #44)

@krida2000 krida2000 marked this pull request as ready for review July 25, 2022 11:53
@tyranron tyranron merged commit 1c7988f into main Jul 27, 2022
@tyranron tyranron deleted the 44-fix-mobile-call-drag-down branch July 27, 2022 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement of existing features or bugfix k::UI/UX UI (user interface) and UX (user experience) changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix GestureDetector drag down on mobile call
3 participants