Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows local notifications (#439) #492

Merged
merged 26 commits into from
Aug 16, 2023
Merged

Windows local notifications (#439) #492

merged 26 commits into from
Aug 16, 2023

Conversation

krida2000
Copy link
Contributor

@krida2000 krida2000 commented Jul 25, 2023 •
edited by SleepySquash
Loading

Resolves #439

Synopsis

Уведомлений нет на Windows.

Solution

Уведомления на Windows будут добавлены.

Checklist

  • Created PR:
    • In draft mode
    • Name contains issue reference
    • Has type and k:: labels applied
  • Before review:
    • Documentation is updated (if required)
    • Tests are updated (if required)
    • Changes conform code style
    • CHANGELOG entry is added (if required)
    • FCM (final commit message) is posted or updated
    • Draft mode is removed
  • Review is completed and changes are approved
    • FCM (final commit message) is approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • All temporary labels are removed

@krida2000 krida2000 added enhancement Improvement of existing features or bugfix k::UI/UX UI (user interface) and UX (user experience) changes labels Jul 25, 2023
@krida2000 krida2000 added this to the 0.1.0-alpha.10 milestone Jul 25, 2023
@krida2000 krida2000 self-assigned this Jul 25, 2023
@krida2000
Copy link
Contributor Author

krida2000 commented Aug 3, 2023 •
edited by SleepySquash
Loading

FCM

Use `win_toast` for local notifications on Windows (#492, #439)

Additionally:
- fix `ChatForward` text losing selection
- fix `TimeLabelWidget` blocking input in `Chat`

SleepySquash
SleepySquash requested changes Aug 4, 2023
View reviewed changes
lib/domain/service/notification.dart Outdated Show resolved Hide resolved
lib/domain/service/notification.dart Outdated Show resolved Hide resolved
SleepySquash
SleepySquash reviewed Aug 9, 2023
View reviewed changes
lib/domain/service/notification.dart Outdated Show resolved Hide resolved
lib/domain/service/notification.dart Outdated Show resolved Hide resolved
@SleepySquash SleepySquash marked this pull request as ready for review August 9, 2023 10:21
@SleepySquash SleepySquash added the platform::windows Specific to Windows platform label Aug 9, 2023
SleepySquash
SleepySquash requested changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@SleepySquash SleepySquash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krida2000, обсудили: почему-то не приходят уведомляшки в группах. Посмотрите, пожалуйста, хотелось бы в рамках этого PRа оперативно поправить тогда, вероятно проблема в ChatWorkerе.

@SleepySquash SleepySquash merged commit 8f0107b into main Aug 16, 2023
21 checks passed
@SleepySquash SleepySquash deleted the 439-windows-local-notifications branch August 16, 2023 12:32
github-actions bot added a commit that referenced this pull request Aug 16, 2023
@github-actions
Use win_toast for local notifications on Windows (#492, #439)
1539660 
Additionally:
- fix `ChatForward` text losing selection
- fix `TimeLabelWidget` blocking input in `Chat` 8f0107b
SleepySquash pushed a commit that referenced this pull request Aug 18, 2023
@krida2000 @SleepySquash
Use win_toast for local notifications on Windows (#492, #439)
4ef3352 
Additionally:
- fix `ChatForward` text losing selection
- fix `TimeLabelWidget` blocking input in `Chat`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SleepySquash SleepySquash SleepySquash approved these changes

Assignees

@krida2000 krida2000

Labels
enhancement Improvement of existing features or bugfix k::UI/UX UI (user interface) and UX (user experience) changes platform::windows Specific to Windows platform
Projects
None yet
Milestone
0.1.0-alpha.9.3
Development

Successfully merging this pull request may close these issues.

Notifications on Windows
2 participants
@krida2000 @SleepySquash