Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesign Badges in CustomNavigationBar (#500) #529

Merged
merged 12 commits into from
Aug 29, 2023
Merged

Redesign Badges in CustomNavigationBar (#500) #529

merged 12 commits into from
Aug 29, 2023

Conversation

drygbezdrug
Copy link
Contributor

@drygbezdrug drygbezdrug commented Aug 25, 2023 •
edited by SleepySquash
Loading

Resolves #500

Synopsis

Бейджики CustomNavigationBar выглядят не очень хорошо.

Solution

Перенес новый дизайн бейджиков с ветки new-design-preview

Checklist

  • Created PR:
    • In draft mode
    • Name contains issue reference
    • Has type and k:: labels applied
  • Before review:
    • Documentation is updated (if required)
    • Tests are updated (if required)
    • Changes conform code style
    • CHANGELOG entry is added (if required)
    • FCM (final commit message) is posted or updated
    • Draft mode is removed
  • Review is completed and changes are approved
    • FCM (final commit message) is approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • All temporary labels are removed

@drygbezdrug drygbezdrug added enhancement Improvement of existing features or bugfix k::design Changes of application architecture and implementation design k::refactor Refactor changes of existing code labels Aug 25, 2023
@drygbezdrug drygbezdrug added this to the 0.1.0-alpha.10 milestone Aug 25, 2023
@drygbezdrug drygbezdrug self-assigned this Aug 25, 2023
@drygbezdrug
Copy link
Contributor Author

FCM

Redesign `Badge`s in `CustomNavigationBar` (#529, #500)

@drygbezdrug drygbezdrug marked this pull request as ready for review August 25, 2023 10:16
SleepySquash
SleepySquash requested changes Aug 25, 2023
View reviewed changes
lib/themes.dart Outdated Show resolved Hide resolved
@SleepySquash SleepySquash added k::UI/UX UI (user interface) and UX (user experience) changes and removed k::design Changes of application architecture and implementation design labels Aug 29, 2023
@SleepySquash SleepySquash merged commit 0589fed into main Aug 29, 2023
21 checks passed
@SleepySquash SleepySquash deleted the 500-redesign-badges-in-custom-navigation-bar branch August 29, 2023 08:42
github-actions bot added a commit that referenced this pull request Aug 29, 2023
@github-actions
Redesign Badges in CustomNavigationBar (#529, #500)
115f292 
Additionally:
- use `rive_common` fork temporary

Co-authored-by: SleepySquash <nordnikita@icloud.com> 0589fed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SleepySquash SleepySquash SleepySquash approved these changes

Assignees

@drygbezdrug drygbezdrug

Labels
enhancement Improvement of existing features or bugfix k::refactor Refactor changes of existing code k::UI/UX UI (user interface) and UX (user experience) changes
Projects
None yet
Milestone
0.1.0-alpha.9.3
Development

Successfully merging this pull request may close these issues.

Redesign Badges in CustomNavigationBar
2 participants
@drygbezdrug @SleepySquash