Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesign auth page (#564) #533

Merged
merged 68 commits into from
Sep 21, 2023
Merged

Redesign auth page (#564) #533

merged 68 commits into from
Sep 21, 2023

Conversation

drygbezdrug
Copy link
Contributor

@drygbezdrug drygbezdrug commented Aug 28, 2023 •
edited by SleepySquash
Loading

Resolves #564
Resolves #588

Synopsis

Страница авторизации не обновлена

Solution

Перенести новый дизайн страницы авторизации с ветки new-design-preview

Checklist

  • Created PR:
    • In draft mode
    • Name contains issue reference
    • Has type and k:: labels applied
  • Before review:
    • Documentation is updated (if required)
    • Tests are updated (if required)
    • Changes conform code style
    • CHANGELOG entry is added (if required)
    • FCM (final commit message) is posted or updated
    • Draft mode is removed
  • Review is completed and changes are approved
    • FCM (final commit message) is approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • All temporary labels are removed

@drygbezdrug drygbezdrug self-assigned this Aug 28, 2023
@drygbezdrug
Copy link
Contributor Author

drygbezdrug commented Sep 6, 2023 •
edited
Loading

@SleepySquash запушил валидацию емейла, хотел убедиться, я двигаюсь в правильном направлении?

@SleepySquash
Copy link
Contributor

@drygbezdrug, дифф на +2,995 −405 оценить? Опишите Ваш алгоритм действий, мне не нужен код на данной этапе. Расскажите, как Вы будете решать проблему, сколько времени это займёт, какие функции и где должны вызываться, не более. Это займёт совсем немного времени, зато мы сможем скорректировать Ваши действия. Что куда нужно добавить, что сделать и так далее?

@SleepySquash
Copy link
Contributor

@drygbezdrug, и я просил дать оценку по трудозатратам задачи, потому что от этой оценки будет зависеть, нужно ли пилить костыль сейчас или нет. Сначала проговорите алгоритм действий, опишите что где делать, оцените по времени и затратам, а затем сделаем вывод.

@SleepySquash
Copy link
Contributor

@drygbezdrug, кстати, страница авторизации плюс минус новая согласована на new-design-preview - обновите дизайн, пожалуйста. Там только кнопка "Стили" лишняя, её нужно убрать, там не должно такого быть, снизу только 2 кнопки.

@drygbezdrug
Copy link
Contributor Author

drygbezdrug commented Sep 6, 2023 •
edited
Loading

@SleepySquash Нет, я не прошу посмотреть все файлы, а только те, что были в последнем коммите (commit Refactor email and emailCode)
У меня алгоритм получился такой:

  • в onsubmitted email'a вызывается метод getEmailCode, в котором signUp и AddUserEmail
  • в onsubmitted emailcode метод confirmEmailCode.
    getEmailCode и confirmEmailCode описаны в /store/auth.dart

SleepySquash
SleepySquash reviewed Sep 6, 2023
View reviewed changes
lib/ui/page/login/controller.dart Outdated Show resolved Hide resolved
lib/store/auth.dart Outdated Show resolved Hide resolved
lib/store/auth.dart Outdated Show resolved Hide resolved
@drygbezdrug drygbezdrug added enhancement Improvement of existing features or bugfix k::UI/UX UI (user interface) and UX (user experience) changes k::refactor Refactor changes of existing code labels Sep 6, 2023
@drygbezdrug drygbezdrug added this to the 0.1.0-alpha.10 milestone Sep 6, 2023
@drygbezdrug
Copy link
Contributor Author

Думаю еще над названием overrideToken, подходящее или нет

SleepySquash
SleepySquash requested changes Sep 19, 2023
View reviewed changes
lib/domain/service/auth.dart Outdated Show resolved Hide resolved
lib/provider/gql/base.dart Outdated Show resolved Hide resolved
lib/provider/gql/components/user.dart Outdated Show resolved Hide resolved
lib/ui/page/auth/widget/cupertino_button.dart Outdated Show resolved Hide resolved
lib/ui/page/login/view.dart Show resolved Hide resolved
SleepySquash
SleepySquash approved these changes Sep 21, 2023
View reviewed changes
lib/themes.dart Outdated Show resolved Hide resolved
lib/provider/gql/base.dart Show resolved Hide resolved
@SleepySquash SleepySquash merged commit 9f450ce into main Sep 21, 2023
21 checks passed
@SleepySquash SleepySquash deleted the redesign-auth-page branch September 21, 2023 13:15
github-actions bot added a commit that referenced this pull request Sep 21, 2023
@github-actions
Redesign Auth page and Login modal (#533, #564, #588)
9282a6d 
- add `SignButton` and `PrefixButton` widgets
- add `displayBold` and `displayTiny` styles to `Fonts`
- impl `AuthRepository.signUpWithEmail`
- refactor `GraphQlClient` to use `RawClientOptions` for token assignment
- redesign `AnimatedLogo` widget

Additionally:
- fix `AnimatedLogo` animation glitching
- remove `rive` dependency

Co-authored-by: SleepySquash <nordnikita@icloud.com> 9f450ce
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SleepySquash SleepySquash SleepySquash approved these changes

Assignees

@drygbezdrug drygbezdrug

Labels
enhancement Improvement of existing features or bugfix k::refactor Refactor changes of existing code k::UI/UX UI (user interface) and UX (user experience) changes
Projects
Roadmap
Status: Done
Milestone
0.1.0-alpha.10
Development

Successfully merging this pull request may close these issues.

AnimatedLogo glitches a bit while animating Redesign auth page
2 participants
@drygbezdrug @SleepySquash