Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Restore button displayed with incorrect position on mobile (#758) #763

Merged
merged 3 commits into from
Dec 25, 2023
Merged

Fix Restore button displayed with incorrect position on mobile (#758) #763

merged 3 commits into from
Dec 25, 2023

Conversation

krida2000
Copy link
Contributor

@krida2000 krida2000 commented Dec 25, 2023 •
edited by SleepySquash
Loading

Resolves #758

Synopsis

На мобильном устройстве кнопка отмены удаления съезжает вниз за границы видимой области списка чатов/контактов.

Solution

Проблема будет решена.

Checklist

  • Created PR:
    • In draft mode
    • Name contains issue reference
    • Has type and k:: labels applied
  • Before review:
    • Documentation is updated (if required)
    • Tests are updated (if required)
    • Changes conform code style
    • CHANGELOG entry is added (if required)
    • FCM (final commit message) is posted or updated
    • Draft mode is removed
  • Review is completed and changes are approved
    • FCM (final commit message) is approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • All temporary labels are removed

@krida2000 krida2000 added enhancement Improvement of existing features or bugfix k::UI/UX UI (user interface) and UX (user experience) changes labels Dec 25, 2023
@krida2000 krida2000 added this to the 0.1.0-alpha.12 milestone Dec 25, 2023
@krida2000 krida2000 self-assigned this Dec 25, 2023
@krida2000
Copy link
Contributor Author

krida2000 commented Dec 25, 2023 •
edited by SleepySquash
Loading

FCM

Fix restore `Chat` or `Contact` button ignoring `SafeArea` (#763, #758)

@krida2000 krida2000 marked this pull request as ready for review December 25, 2023 10:28
@SleepySquash SleepySquash merged commit 05b3f8f into main Dec 25, 2023
22 checks passed
@SleepySquash SleepySquash deleted the 758-fix-restore-button-position-on-mobile branch December 25, 2023 15:07
github-actions bot added a commit that referenced this pull request Dec 25, 2023
@github-actions
Fix restore Chat or Contact button ignoring SafeArea (#763, #758)
f94bbcf 
05b3f8f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SleepySquash SleepySquash SleepySquash approved these changes

Assignees

@krida2000 krida2000

Labels
enhancement Improvement of existing features or bugfix k::UI/UX UI (user interface) and UX (user experience) changes
Projects
None yet
Milestone
0.1.0-alpha.12
Development

Successfully merging this pull request may close these issues.

Restore button popup on Chat/Contact swipe isn't displayed correctly
2 participants
@krida2000 @SleepySquash