Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix call ringtone not being looped on macOS #90

Merged
merged 1 commit into from
Aug 23, 2022
Merged

Fix call ringtone not being looped on macOS #90

merged 1 commit into from
Aug 23, 2022

Conversation

SleepySquash
Copy link
Contributor

@SleepySquash SleepySquash commented Aug 23, 2022 •
edited
Loading

Synopsis

Call plays an audio when calling or being called.

Solution

This PR fixes this audio not being looped on macOS by changing the PlayerMode to mediaPlayer (lowLatency currently set is not widely supported on macOS).

Checklist

  • Created PR:
    • In draft mode
    • Name contains issue reference
    • Has type and k:: labels applied
  • Before review:
    • Documentation is updated (if required)
    • Tests are updated (if required)
    • Changes conform code style
    • CHANGELOG entry is added (if required)
    • FCM (final commit message) is posted or updated
    • Draft mode is removed
  • Review is completed and changes are approved
    • FCM (final commit message) is approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • All temporary labels are removed

@SleepySquash SleepySquash added enhancement Improvement of existing features or bugfix k::refactor Refactor changes of existing code labels Aug 23, 2022
@SleepySquash SleepySquash added this to the 0.1.0-alpha.6 milestone Aug 23, 2022
@SleepySquash SleepySquash self-assigned this Aug 23, 2022
@SleepySquash
Copy link
Contributor Author

FCM

Fix `Call` ringtone not being looped on macOS (#90)

@SleepySquash SleepySquash marked this pull request as ready for review August 23, 2022 09:43
@SleepySquash SleepySquash merged commit 11fe7b6 into main Aug 23, 2022
@SleepySquash SleepySquash deleted the fix-macos-audio-not-looping branch August 23, 2022 09:47
github-actions bot added a commit that referenced this pull request Aug 23, 2022
@github-actions
Fix Call ringtone not being looped on macOS (#90) 11fe7b6
abbe74b
@SleepySquash SleepySquash added the platform::macos Specific to macOS platform label Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@SleepySquash SleepySquash

Labels
enhancement Improvement of existing features or bugfix k::refactor Refactor changes of existing code platform::macos Specific to macOS platform
Projects
None yet
Milestone
0.1.0-alpha.6
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@SleepySquash