Fix #27: Work around mypy messing up __init__ #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddanier
force-pushed
the
dev/#27-work-around-mypy-wanting-provate-slotsin-__init__
branch
from
56f88e3
to
06a81a9
Compare
|
Any reason why this hasn't been merged yet? This would help us a lot, I'm just trying to understand the reason. Thank you! |
|
@ahopey Sorry just haven't got the time. I wanted to think this through again, as the current solution feel a little bit like a workaround. Will try to get this resolved soon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mark new slots introduced in
ChangeDetectionMixinasPrivateAttr, although they are never used like this.mypywill then not think you are required to pass those attributes to__init__