Skip to content
This repository has been archived by the owner on Jan 24, 2023. It is now read-only.

Climber PID magik #4

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Climber PID magik #4

wants to merge 15 commits into from

Conversation

WAaron-500
Copy link

No description provided.

@WAaron-500 WAaron-500 requested a review from hadley31 May 12, 2022 01:03
@hadley31
Copy link
Member

Here are some ideas I have:

  1. Introduce a boolean method in climber which returns if pid is at setpoint.
  2. Climber position PID commands - isFinished should return whether the controller is at the setpoint. Or possibly have a boolean option to immediately finish or wait.
  3. Revert to individual climber subsystem modules (I can elaborate on this later)
  4. Is the PID slots so that we can use different instances? Like have a pid for velocity and one for position? If so, we should use slot 1 for position

@WAaron-500
Copy link
Author

WAaron-500 commented May 19, 2022

Alright Nick I have Implemented 1 and 2 without problems, I think and in doing so I think I may have found something that could have done a real bad, but I think I fixed it... had to do with something not stopping when its supposed to.

NVM I FOUND IT TURNS OUT THERE IS A SUBTLE DIFFERENCE BETWEEN WHAT I WAS REFERING TO 4 being pushed soon

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants