Add absent RRuleSet getters (GetRDate(), ...), extract StrSliceToRRuleSet() and StrToDates() functions #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
May 17, 2018 16:13
This one is useful in case your app has to deal with array of strings encoding recurrence set from the beginning, for example if you receive event json response from google calendar api, recurrence set is encoded with an array of strs there, not with single str with all rules concated
egorbunov
changed the title
GetRDate(), ...), extract StrSliceToRRuleSet() and StrToDates() functions
egorbunov
changed the title
GetRDate(), ...), extract StrSliceToRRuleSet() and StrToDates() functions
|
Thanks 😎 But review is still expected, I guess :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetRDate()and other getters for rrule Set seem to be useful when working with rrule Set after parsing it from stringStrSliceToRRuleSet()takes array of strings, each encoding one RRULE, EXDATE, and so on. This one may be useful when not single string encoding rrule Set is passed to application, but array of strings as it is done when using Google Calendar APIStrToDates()added and made exported so that user may implement it's own logic during rrule Set construction and decide which parsed from string EXDATE/RDATE should be included in the set and which should not