Be more careful parsing local times in rules #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
October 18, 2018 19:09
More straightforward: parse roption first, and when create rrule
Rationale: that is needed because rules may contain local time (time strings without time zone specified). Also time zone parsed from DTSTART now properly used to parse any other local times appearing in the rrule set
This parsing results to the first second of the day specified by date
4 similar comments
|
@rickywiens, if you are still interested, please, check my additions |
rickywiens
approved these changes
Oct 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
This patch makes package a little bit more flexible in parsing rrule sets including local times.
For example in RDATE/EXDATE, as RFC5545 states, there may be no time zone info to parse
date time in.
That seems to impossible to implement floating time using standard go time structure. So that is
handy to make it possible for user to specify in which location such times are parsed by default.
Also it is natural to use DTSART time zone as a fallback for RDATE/EXDATE local time dates.