Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honor TZID when evaluating UNTIL [Issue 37] #38

Closed
wants to merge 1 commit into from

Conversation

Ferix9288
Copy link

Issue: #37

Easy fix where I call StrToROptionInLocation with defaultLoc instead of just StrToROption that defaults to UTC.

		case "RRULE", "EXRULE":
			rOpt, err := StrToROptionInLocation(rule, defaultLoc)
			if err != nil {
				return nil, fmt.Errorf("StrToROption failed: %v", err)
			}

Other notable changelog:

  • Updated TestStrSet and TestRFCSet so that the UNTIL now respects UTC or NY timezone
  • Added a testcase and imported assert and require library. I'm ok with rejecting this added testcase.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.663% when pulling 3c634b3 on Ferix9288:fix_issue_37 into c4b1bf2 on teambition:master.

@Ferix9288
Copy link
Author

Never mind. Looks like this is intentional behavior based on the RFC spec.

@Ferix9288 Ferix9288 closed this Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants