Minimize new atoms

teamcapybara · May 13, 2019 · e3b0a98 · e3b0a98
1 parent 74c6b43
commit e3b0a98
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 9 deletions.
diff --git a/lib/capybara/selenium/node.rb b/lib/capybara/selenium/node.rb
@@ -155,7 +155,7 @@ def disabled?
   end
 
   def content_editable?
-    native.attribute('isContentEditable') == "true"
+    native.attribute('isContentEditable') == 'true'
   end
 
   def ==(other)

diff --git a/lib/capybara/selenium/patches/atoms.rb b/lib/capybara/selenium/patches/atoms.rb
@@ -6,16 +6,18 @@ module CapybaraAtoms
 private # rubocop:disable Layout/IndentationWidth
 
   def read_atom(function)
-    # @atoms ||= Hash.new { |hash, key|
-    #   hash[key] = ::Uglifier.compile(File.read(File.expand_path("../../atoms/#{key}.js", __FILE__)),
-    #     compress: {
-    #       negate_iife: false
-    #     }
-    #   )[0...-1]
-    # }
     @atoms ||= Hash.new do |hash, key|
-      hash[key] = File.read(File.expand_path("../../atoms/#{key}.js", __FILE__))
+      hash[key] = ::Uglifier.compile(
+        File.read(File.expand_path("../../atoms/#{key}.js", __FILE__)),
+        compress: {
+          negate_iife: false, # Negate immediately invoked function expressions to avoid extra parens
+          side_effects: false # Pass false to disable potentially dropping functions marked as "pure"
+        }
+      )[0...-1]
     end
+    # @atoms ||= Hash.new do |hash, key|
+    #   hash[key] = File.read(File.expand_path("../../atoms/#{key}.js", __FILE__))
+    # end
     @atoms[function]
   end
 end