HTML includes XML declaration and DOCTYPE on JRuby #570
Comments
|
Why is it a problem? Are you doing something which checks the XML instruction or Doctypes? If so, why? |
|
Because it is not displayed by a browser. When using launchy, for example
|
|
I still don't understand, the problem is that it is not shown, how is that a problem? |
|
The generated HTML cannot be displayed by the browser because the first line is XML declaration. Even more than that, the doctype is not the same as declared I the views. Have I explained the problem? This is definitely a bug which doesn't seem to happen on MRI. On 15/12/2011, at 23:28, Jonas Nicklasreply@reply.github.com wrote:
|
|
Hmm, strange. Browsers should generally ignore an XML declaration, except that it may throw the browser into quirks mode IIRC. Have you tried this in multiple browsers? |
|
I don't know why browsers should ignore that. Why are we even discussing that... And it doesn't seems to work in Chrome, Safari and FF. On 19/12/2011, at 20:03, Jonas Nicklasreply@reply.github.com wrote:
|
|
No, it's not obviously just plain wrong. In fact the HTML5 specification requires HTML documents using the XML syntax to specify an XML declaration at the top of the document. See: http://www.w3.org/TR/html-markup/syntax.html#character-encoding. Now in this case, the doctype is HTML 4.01 Transitional, which is not an XML based format. However in some old browsers, adding the XML declaration had some effect on quirks/standards mode, I think it still does, but I can't remember. Furthermore, Capybara has nothing to do with adding this XML declaration, that's Nokogiri's doing. It seems a bit idiotic for Nokogiri to add this xml declaration, but I don't think they are wrong in adding it. In any case, this is not something we can fix in Capybara. |
|
Maybe you can help guys at Nokogiri to solve this issue by explaining better where it misbehaves? |
|
@jnicklas actually it is a problem with Capybara. I was trying to make a minimal repro for Nokogiri, but it just worked. The issue is this: page.html.lines.first # "<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n"
page.body.lines.first # "<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n"
page.source.lines.first # "<!DOCTYPE html>\n"And the |
|
The workaround is NOT to use require 'capybara/util/save_and_open_page'
Capybara.save_and_open_page(page.source)To fix it, I believe |
|
Hi there! This is happening to me, too. I just upgraded from Capybara 0.4 to 1.1. Everything works OK in my laptop (ruby 1.9.2p180), but my spec fail in my CI server (ruby 1.9.2-p0, 64 bits machine). I'll try to make a simple failing test. The problem, as you said, is that there's an extra "", so some parsing by capybara breaks. Nokogiri has been kept at the same version (1.5.0), so I think this is something related with Capybara. |
Under JRuby 1.6.5 (1.9 mode) the
page.htmlreturns something that looks like:We can clearly see that
<?xml version="1.0" encoding="UTF-8">has been inserted which is just plain wrong.Also the DOCTYPE is transitional HTML 4.01, but this is not correct either because the page was generated with DOCTYPE for HTML5.
This doesn't happen on MRI 1.9.3.
Any clues how to fix/workaround it?
(using rack driver).
The text was updated successfully, but these errors were encountered: