Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add refute_selector as alias of assert_no_selector #1234

Merged
merged 1 commit into from Jan 31, 2014

Conversation

gregmolnar
Copy link
Contributor

No description provided.

@jnicklas
Copy link
Collaborator

Is this a common idiom? Do libraries usually provide refute_* assertions? I never use the xUnit style, so I have no idea. Please add tests regardless.

@gregmolnar
Copy link
Contributor Author

I've added a test and rebased.
Regarding the other libraries in minitest assertions has a refute pair: http://www.ruby-doc.org/stdlib-1.9.3/libdoc/minitest/unit/rdoc/MiniTest/Assertions.html#method-i-refute so for instance instead of assert_not_empty you can use refute_empty which in my opinion sounds better. But it might be just a matter of taste :).

jnicklas added a commit that referenced this pull request Jan 31, 2014
add refute_selector as alias of assert_no_selector
@jnicklas jnicklas merged commit fbd0ecf into teamcapybara:master Jan 31, 2014
@jnicklas
Copy link
Collaborator

Good enough for me :) thanks!

@gregmolnar
Copy link
Contributor Author

Thanks for merging it!
On 31 Jan 2014 13:46, "Jonas Nicklas" notifications@github.com wrote:

Good enough for me :) thanks!


Reply to this email directly or view it on GitHubhttps://github.com//pull/1234#issuecomment-33791187
.

@abotalov abotalov added this to the Capybara 2.3 milestone Feb 6, 2014
@semaperepelitsa
Copy link

I think "assert_no_text" and "assert_no_title" should also have "refute" aliases?

@gregmolnar gregmolnar deleted the refute branch September 6, 2014 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants