use BasicObject so global includes don't break CSSHandlers #1279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you know which method collides in case of including |
|
concat is the primary one -- but basically any function that is matches an xpath function would create a problem if its included into global scope (which includes into Object) |
twalpole
added a commit
that referenced
this pull request
Apr 2, 2014
use BasicObject so global includes don't break CSSHandlers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Derive CSSHandlers from BasicObject so global includes of modules with functions that collide with xpath function names (like ActionView::Helpers::TextHelper#concat) don't cause failures