Fix :button selector evaluating :link_or_button expression filters #2131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twalpole
force-pushed
the
link_or_button_expression
branch
from
b7d10af
to
99790eb
Compare
|
Yes, this seems to fix my issue, thank you. It figures the one time I don't think it's a bug so I post to the group, it turns out to be a bug. |
|
@shepmaster Sorry about this one -- Definitely was not intended to break the use case of modifying the filter. Thanks for reporting it. I'll release 3.11.1 in a few hours. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue mentioned in https://groups.google.com/forum/#!topic/ruby-capybara/-RBMNqYvEuo .
When the link_or_button selector combines the link and button selectors expression_filters refers to the link_or_button selector which ends up creating incorrect attribute matchers. This fixes it by limiting to only expected attributes.