Fix access to specializations when Selenium::Driver is subclassed #2185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The specializations are stored in a class instance variable. However,
they are accessed from the specialize_driver method via `self.class`.
Previously if this method was called on an instance of a subclass of
Selenium::Driver, then it accessed the class instance variable
associated with the subclass (which is nil by default) and not the class
instance variable associated with the Selenium::Driver class as intended
resulting in an exception like this:
NoMethodError:
private method `select' called for nil:NilClass
./lib/capybara/selenium/driver.rb:417:in `specialize_driver'
./lib/capybara/selenium/driver.rb:49:in `browser'
./lib/capybara/selenium/driver.rb:66:in `visit'
./lib/capybara/session.rb:277:in `visit'
./spec/selenium_spec_chrome.rb:118:in `block (3 levels) in <top (required)>'
This commit adds a spec using a subclass of Selenium::Driver with Chrome
to demonstrate the problem and fixes it by changing the
specialize_driver method to access the specializations via the
explicitly specified class name.
An alternative fix would be to use a class variable for specializations
and do away with the class attribute reader altogether.
Pull Request Test Coverage Report for Build 6049
💛 - Coveralls |
|
Thanks for this! Going forward I think I'd like this to be implemented in a way that allows for subclasses to override |
|
Thanks! 👍 |
floehopper
deleted the
fix-access-to-specializations-when-selenium-driver-is-subclassed
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This problem was introduced in this commit (i.e. since the v3.17.0 release) and is causing
NoMethodErrorexceptions in all the JS-related feature specs in an app I'm working on.The specializations are stored in a class instance variable. However, they are accessed from the
#specialize_drivermethod viaself.class.Previously if this method was called within an instance of a subclass of
Selenium::Driver, then it accessed the class instance variable associated with the subclass (which isnilby default) and not the class instance variable associated with theSelenium::Driverclass as intended resulting in an exception like this:This commit adds a spec using a subclass of
Selenium::Driverwith Chrome to demonstrate the problem and fixes it by changing the#specialize_drivermethod to access the specializations via the explicitly specified class name rather than viaself.class.An alternative fix would be to use a class variable for specializations and do away with the class attribute reader altogether.