Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Addressable::URI.join to merge base_uri and visit_uri #2728

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

akmhmgc
Copy link

@akmhmgc akmhmgc commented Dec 23, 2023

Description

If Capybara.app_hostcontains / at the end (eg. http://www.google.com/) and visit_uri.path exists, visit_uri_parts[:path] return the path having // and the test fails like below.

Capybara.app_host  = "http://localhost.local/"

it 'failed_test' do
    visit "/path"
    # page.current_path returns  '//path' and test fails
    expect(page).to have_current_path '/path'
end

So, I use Addressable::URI.join.

path1 = '/'
path2 = '/path'

Addressable::URI.join(path1, path2).path
# => "/path"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant