New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hover and resize window support #965
Conversation
@abotalov I'm pretty sure it gets reset for every test in Capybara::SpecHelper::reset! - if I'm wrong about that I'll be happy to store and reset the setting |
Also please take a look at Selenium's Window class. Do we need separate class? I think no but want to point it out |
Imo, we could combine this with a more sensible alternative to |
@jnicklas Moving window related functions to a Capybara::Driver::Window class is fine, but I'm not sure what you're suggesting with within_window. Are you saying that one shouldnt be able to just call resize_window or window.size(xxx,yyy) in the current session to resize the current window? |
@@ -203,6 +203,14 @@ def drag_to(node) | |||
synchronize { base.drag_to(node.base) } | |||
end | |||
|
|||
## | |||
# | |||
# move mouse over the Element |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First word should be "Move". Sentence case is used in other comments in this file.
@twalpole Please don't add different features in the same pull request next time when you will do it. It will make review easier |
@driver=driver | ||
end | ||
|
||
def size |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add YARD comments for size
and resize
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@abotalov There hasnt been agreement on the API yet, I would clean it all up when there is
@abotalov The only reason they were in the same PR was because they were discussed in the same issue referenced above. |
I dont dealing find dealing with @aboltalov to be worth doing this, closing PR, someone else can add this feature if its wanted |
Was this feature ever merged or implemented in any way? Thanks! |
This pull request is an attempt at contributing to issue #832 - It implements an api for hover and resize_window. Unfortunately hover doesnt work with firefox on osx (works properly using chrome via webdriver) due to what appear to be positional bugs in selenium