Remove EqualsAvoidNull check from Qulice

[mkordas]

Currently Qulice prohibits code like

input.equals("contents")

in favour of

"contents".equals(input)

The reason behind this is to avoid null pointer exceptions when input is null. However, IMO it's just hiding a problem, while code should be fragile. Moreover, in well written code input should never be null anyway.

Second reason to remove this check is that inverted notation is unnatural and less readable.

In scope of this issue I expect that check is removed and test is added proving that first syntax is allowed.

[krzyk]

@davvd valid bug

[davvd]

@davvd valid bug

@krzyk added "bug" tag to this issue

[davvd]

@mkordas thanks for the report, I topped your acc for 15 mins, payment ID 57c3fe5a6d5f4b008819f535

[kanghj]

@davvd @mkordas I have made PR #809 for this.

[mkordas]

@kanghj #807 is this issue :)

[kanghj]

@mkordas, my bad! Edited the original comment

[davvd]

@davvd @mkordas I have made PR #809 for this.

@kanghj thank you!

[krzyk]

@0crat in

[0crat]

@0crat in (here)

@krzyk Job #807 is now in scope, role is DEV

[0crat]

@0crat in (here)

@krzyk Thanks for your contribution, @mkordas/z! If you would be a member of the project, you would now earn +15 reputation points, as explained in §29. You can join and apply to it, see §2.

[krzyk]

@mkordas Change was merged in #809, please close

[0crat]

@krzyk/z everybody who has role DEV are banned at this job; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

[0crat]

@krzyk/z everybody who has role DEV are banned at this job; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

[mkordas]

@krzyk thanks for merging!

[0crat]

The job #807 is now out of scope