Skip to content

Commit

Permalink
feat(webauthn): change default attestation mode
Browse files Browse the repository at this point in the history
Changes the default attestation conveyance preference from 'none' to 'direct' for better AAGUID handling on Windows.

Co-authored-by: Stefan Jacobi <stefan.jacobi@adesso.de>
  • Loading branch information
shentschel and Stefan Jacobi committed Apr 10, 2024
1 parent 317b0b6 commit 01fa397
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions backend/handler/webauthn.go
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ func NewWebauthnHandler(cfg *config.Config, persister persistence.Persister, ses
RPDisplayName: cfg.Webauthn.RelyingParty.DisplayName,
RPID: cfg.Webauthn.RelyingParty.Id,
RPOrigins: cfg.Webauthn.RelyingParty.Origins,
AttestationPreference: protocol.PreferNoAttestation,
AttestationPreference: protocol.PreferDirectAttestation,
AuthenticatorSelection: protocol.AuthenticatorSelection{
RequireResidentKey: &f,
ResidentKey: protocol.ResidentKeyRequirementDiscouraged,
Expand Down Expand Up @@ -113,7 +113,7 @@ func (h *WebauthnHandler) BeginRegistration(c echo.Context) error {
ResidentKey: protocol.ResidentKeyRequirementRequired,
UserVerification: protocol.UserVerificationRequirement(h.cfg.Webauthn.UserVerification),
}),
webauthn.WithConveyancePreference(protocol.PreferNoAttestation),
webauthn.WithConveyancePreference(protocol.PreferDirectAttestation),
// don't set the excludeCredentials list, so an already registered device can be re-registered
)

Expand Down

0 comments on commit 01fa397

Please sign in to comment.