fix: don't override error before return (#1447)

teamhanko · Apr 29, 2024 · 4bea1e3 · 4bea1e3
1 parent 9c799d2
commit 4bea1e3
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/backend/handler/webauthn.go b/backend/handler/webauthn.go
@@ -200,9 +200,9 @@ func (h *WebauthnHandler) FinishRegistration(c echo.Context) error {
 				errorMessage = fmt.Sprintf("%s: %s: %s", errorMessage, err.Details, err.DevInfo)
 				errorStatus = http.StatusUnprocessableEntity
 			}
-			err = h.auditLogger.CreateWithConnection(tx, c, models.AuditLogWebAuthnRegistrationFinalFailed, user, errors.New(errorMessage))
-			if err != nil {
-				return fmt.Errorf(CreateAuditLogFailureMessage, err)
+			aErr := h.auditLogger.CreateWithConnection(tx, c, models.AuditLogWebAuthnRegistrationFinalFailed, user, errors.New(errorMessage))
+			if aErr != nil {
+				return fmt.Errorf(CreateAuditLogFailureMessage, aErr)
 			}
 
 			return echo.NewHTTPError(errorStatus, errorMessage).SetInternal(err)