Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve logging on SAML endpoints #1254

Closed
2 tasks done
shentschel opened this issue Dec 13, 2023 · 0 comments
Closed
2 tasks done

Improve logging on SAML endpoints #1254

shentschel opened this issue Dec 13, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@shentschel
Copy link
Collaborator

Checklist

  • I could not find a solution in the existing issues or docs.
  • I agree to follow this project's Code of Conduct.

Description

Currently there is no log of an error in the backend if you use the saml feature. An example would be when your application is not in the right audience. The only response is: an internal error occurred.

Describe your ideal solution

When an error in the authentication process is thrown, there is a log entry in hanko backend.

Workarounds or alternatives

No response

Hanko Version

v0.9.1

Additional Context

No response
@shentschel shentschel added the enhancement New feature or request label Dec 13, 2023
shentschel pushed a commit that referenced this issue Feb 16, 2024
fix(saml): add error logging to handler
6c7bba0 
* add missing error logging as there is no real error output when there is a internal server error
* switch parseSamlResponse errors to invalid request errors.

Fixes: #1254
shentschel pushed a commit that referenced this issue Feb 16, 2024
fix(saml): add error logging to handler
2b6647e 
* add missing error logging as there is no real error output when there is a internal server error
* switch parseSamlResponse errors to invalid request errors.

Fixes: #1254
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Hanko
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shentschel