Feature/saml #1041
Merged
Feature/saml #1041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lfleischmann
reviewed
Oct 6, 2023
shentschel
force-pushed
the
feature/saml
branch
from
06e1bca
to
9ab9cb6
Compare
|
I fixed the merge conflicts in go.mod, go.sum and the doc files with a rebase which lead to the force push (to keep the commit history clean) |
added 3 commits
October 17, 2023 15:37
* add feature to /ee/saml/ * Implement SAML logic with gosaml2 * provide endpoint for metadata and cert download * provide endpoint for authentication and callback * provide endpoint to fetch provider * map SAML attributes to thirdparty claims * map unknown claim - attribute mappings to custom claims * add default claims for generic client and auth0 * implement saml certificate generation * implement saml state generation and persistence (POST request does not get a cookie back and post body was to big for GET Redirect) * expose if an enterprise connection can be used in config dto * add frontend implementation * add docs (First Draft)
* fix typos in config * fix defaults for auth0 -> add schema * change error message in saml certificate db entity creation * change redirectError to use StatusSeeOther (303) to switch from POST to GET request
shentschel
force-pushed
the
feature/saml
branch
from
9ab9cb6
to
2c6a679
Compare
lfleischmann
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the enterprise feature SAML SSO to allow users to use their own Identity Provider.
Implementation
The PR implements gosaml2 to allow communication between IDP and Hanko. The authentication flow itself reuses the third-party auth flow and reuses the same error and cookie structure.
Tests
Add the config from saml.mdx (and configure it to your applications needs) and use auth0 with an SAML APP. Exchange Metadata between hanko and auth0. When starting quickstart with this config you can login with auth0 when using an email address which correlates with a user in auth0 and where the domain of this address is in the domain tag for the identity provider
Todo
I did a go mod tidy and now the go.mod and go.sum do not match with hanko/main. I think that needs to be fixed manually