Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flowpilot login flow #1171

Merged
merged 11 commits into from
Nov 14, 2023
Merged

flowpilot login flow #1171

merged 11 commits into from
Nov 14, 2023

Conversation

lfleischmann
Copy link
Member

No description provided.

@lfleischmann lfleischmann changed the title Flowpilot login flow wip flowpilot login flow Nov 7, 2023
@lfleischmann lfleischmann marked this pull request as ready for review November 7, 2023 09:59
Copy link
Contributor

@FreddyDevelop FreddyDevelop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks, good. But I noticed a weird, every time I logged in through a passcode (normal passcode login or password recovery) I was sent to StateOnboardingCreatePasskey, but when I was login in through a password I got straight to success. Don't know if that is intentional.

backend/mail/templates/recovery_text.tmpl Outdated Show resolved Hide resolved
@lfleischmann
Copy link
Member Author

lfleischmann commented Nov 10, 2023

Looks, good. But I noticed a weird, every time I logged in through a passcode (normal passcode login or password recovery) I was sent to StateOnboardingCreatePasskey, but when I was login in through a password I got straight to success. Don't know if that is intentional.

Added start of onboarding subflow after PW (if enabled and WA available).

@bjoern-m bjoern-m merged commit dbb8829 into introduce_flowpilot Nov 14, 2023
@bjoern-m bjoern-m deleted the flowpilot-login-flow-wip branch November 14, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants