Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:add passcode.zh-CN.yaml for support chinese #1219

Merged
merged 1 commit into from Nov 27, 2023

Conversation

zhaoyii
Copy link
Contributor

@zhaoyii zhaoyii commented Nov 27, 2023

Description

This pull request introduces a new file named passcode.zh-CN.yaml to facilitate support for the Chinese language. This addition aims to enhance the usability and accessibility of our service for Chinese-speaking users.

Implementation

In implementing this feature, I have created a new YAML file containing Chinese translations. This file will be integrated into our existing multilingual support framework. No major code refactoring was involved, primarily adding new localization resources. I would like the reviewers to pay special attention to the accuracy and format of the translations within the file.

Tests

To verify these changes, access the http://host:port/passcode/login/initialize endpoint and include Accept-Language=zh-CN in the request header to simulate a Chinese language environment request. Subsequently, inspect the emails in the test mail server to ensure they are correctly translated into Chinese. This test aims to confirm that Chinese-speaking users receive emails that are appropriately localized and accurately translated.

Note: If using mailslurper to test Chinese, the email content will appear as the following garbled text, which is due to mailslurper's issue with parsing UTF-8. The display is normal in email services like Gmail.

# mailslurper shows

=E5=9C=A8=E6=82=A8=E7=9A=84=E7=99=BB=E5=BD=95=E5=B1=8F=E5=B9=95=E4=B8=8A=E8=
=BE=93=E5=85=A5=E4=BB=A5=E4=B8=8B=E9=AA=8C=E8=AF=81=E7=A0=81=EF=BC=9A

432611

=E9=AA=8C=E8=AF=81=E7=A0=81=E5=9C=A8 5 =E5=88=86=E9=92=9F=E5=86=85=E6=9C=89=
=E6=95=88=E3=80=82

Todos

Currently, this change covers only a portion of the basic text translations into Chinese. Additional translations may be required in the future to expand and refine the existing translations.

Additional Context

This change is geared towards enhancing the service's usability and accessibility among our growing Chinese user base. Localization efforts like this become increasingly vital as the Chinese-speaking audience expands.

@zhaoyii zhaoyii closed this Nov 27, 2023
@zhaoyii
Copy link
Contributor Author

zhaoyii commented Nov 27, 2023

Add a description about the abnormal display of Chinese characters in mailslurper.

@zhaoyii zhaoyii reopened this Nov 27, 2023
@lfleischmann
Copy link
Member

Hi @zhaoyii

can't comment on the correctness of the translations of course but looks good to me otherwise. Thanks!

@lfleischmann lfleischmann merged commit f116cb4 into teamhanko:main Nov 27, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants