Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix retry after error handling #533

Merged
merged 3 commits into from
Jan 30, 2023
Merged

Fix retry after error handling #533

merged 3 commits into from
Jan 30, 2023

Conversation

bjoern-m
Copy link
Contributor

Description

  • Restore the TooManyRequest error properly for passwords and passcodes

Implementation

  • Did a small fix in the SDK's passcode client to throw the error early
  • Adjusted the UI code

@bjoern-m bjoern-m marked this pull request as ready for review January 27, 2023 16:47
@bjoern-m bjoern-m force-pushed the fix-retry-after-error-handling branch from 93db1b9 to 1c1ada4 Compare January 27, 2023 16:47
@like-a-bause like-a-bause merged commit 8c7ed60 into main Jan 30, 2023
@like-a-bause like-a-bause deleted the fix-retry-after-error-handling branch February 1, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FreddyDevelop FreddyDevelop FreddyDevelop approved these changes

@like-a-bause like-a-bause Awaiting requested review from like-a-bause

@lfleischmann lfleischmann Awaiting requested review from lfleischmann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bjoern-m @FreddyDevelop @like-a-bause