feat(elements): use svg icons #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduces icon component - Replaces CSS based loading spinner, checkmark and exclamation mark icons with svgs rendered via icon component - Adds passkey icon for use in "sign in with ..." button - Adds social (Google, GitHub) icons
like-a-bause
approved these changes
Mar 1, 2023
bjoern-m
reviewed
Mar 1, 2023
Co-authored-by: bjoern-m <56024829+bjoern-m@users.noreply.github.com>
bjoern-m
reviewed
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace icons used in
elementswith svg-based icons.Implementation
Iconcomponent that pulls icons vianamefrom a known list of icon names and then renders the respective icon component (each icon is a component that renders ansvgelement)